Integrate custom lints (#1215)

.github/workflows/deploy.yaml

@@ -101,7 +101,7 @@ jobs:
         with:
           commit_message: "Bump app version [no ci]"
 
-      - uses: actions/setup-java@v3
+      - uses: actions/setup-java@v4
         with:
           java-version: ${{env.JAVA_VERSION}}
           distribution: "zulu"

.github/workflows/format_lint_test.yaml

@@ -37,7 +37,7 @@ jobs:
       - name: Clone repository
         uses: actions/checkout@v4
 
-      - uses: actions/setup-java@v3
+      - uses: actions/setup-java@v4
         with:
           java-version: ${{ env.JAVA_VERSION }}
           distribution: zulu
@@ -49,7 +49,11 @@ jobs:
           flutter-version-file: uni/pubspec.yaml
           cache: true
 
-      - run: flutter analyze .
+      - run: flutter pub get
+
+      - run: |
+          flutter analyze .
+          dart run custom_lint
 
   test:
     name: Test
@@ -60,7 +64,7 @@ jobs:
         working-directory: ./uni
     steps:
       - uses: actions/checkout@v4
-      - uses: actions/setup-java@v3
+      - uses: actions/setup-java@v4
         with:
           java-version: ${{ env.JAVA_VERSION }}
           distribution: zulu

uni/analysis_options.yaml

@@ -6,3 +6,5 @@ analyzer:
     - "**.g.dart"
     - "**.mocks.dart"
     - "**generated/**"
+  plugins:
+    - custom_lint

uni/lib/controller/background_workers/background_callback.dart

@@ -32,14 +32,14 @@ Future<void> workerStartCallback() async {
         });
         return true;
       }
-      //try to keep the usage of this function BELOW +-30 seconds
-      //to not be punished by the scheduler in future runs.
+      // try to keep the usage of this function BELOW +-30 seconds
+      // to not be punished by the scheduler in future runs.
       await taskMap[taskName]!.item1();
-    } catch (err, stackTrace) {
+    } catch (err, st) {
       Logger().e(
         'Error while running $taskName job:',
         error: err,
-        stackTrace: stackTrace,
+        stackTrace: st,
       );
       return false;
     }

uni/lib/controller/background_workers/notifications.dart

@@ -125,7 +125,7 @@ class NotificationManager {
     const initializationSettingsAndroid =
         AndroidInitializationSettings('ic_notification');
 
-    //request for notifications immediatly on iOS
+    // request for notifications immediatly on iOS
     const darwinInitializationSettings = DarwinInitializationSettings(
       requestCriticalPermission: true,
     );
@@ -157,7 +157,7 @@ class NotificationManager {
     if (Platform.isAndroid) {
       await Workmanager().cancelByUniqueName(
         'pt.up.fe.ni.uni.notificationworker',
-      ); //stop task if it's already running
+      ); // stop task if it's already running
       await Workmanager().registerPeriodicTask(
         'pt.up.fe.ni.uni.notificationworker',
         'pt.up.fe.ni.uni.notificationworker',

uni/lib/controller/cleanup.dart

@@ -61,7 +61,7 @@ Future<void> cleanDirectory(Directory directory, DateTime threshold) async {
     try {
       final fileDate = file.lastModifiedSync();
       return fileDate.isBefore(threshold) && path.extension(file.path) != '.db';
-    } catch (e) {
+    } catch (err) {
       return false;
     }
   });

uni/lib/controller/fetchers/departures_fetcher.dart

@@ -45,17 +45,17 @@ class DeparturesFetcher {
         callParam.lastIndexOf("'"),
       );
       return csrfToken;
-    } catch (e, stackTrace) {
+    } catch (err, st) {
       unawaited(
         Sentry.captureEvent(
           SentryEvent(
-            throwable: e,
+            throwable: err,
             request: SentryRequest(
               url: url,
               data: response.body,
             ),
           ),
-          stackTrace: stackTrace,
+          stackTrace: st,
         ),
       );
       rethrow;

uni/lib/controller/local_storage/database/app_calendar_database.dart

@@ -21,7 +21,7 @@ class CalendarDatabase extends AppDatabase {
     });
   }
 
-  //Returns a list with all calendar events stored in the database
+  // Returns a list with all calendar events stored in the database
   Future<List<CalendarEvent>> calendar() async {
     final db = await getDatabase();
 

uni/lib/controller/local_storage/database/app_restaurant_database.dart

@@ -93,11 +93,11 @@ class RestaurantDatabase extends AppDatabase {
       whereArgs.add(toString(day));
     }
 
-    //Get restaurant meals
+    // Get restaurant meals
     final List<Map<String, dynamic>> mealsMaps =
         await txn.query('meals', where: whereQuery, whereArgs: whereArgs);
 
-    //Retrieve data from query
+    // Retrieve data from query
     final meals = mealsMaps.map((map) {
       final day = parseDayOfWeek(map['day'] as String);
       final type = map['type'] as String;

uni/lib/controller/local_storage/notification_timeout_storage.dart

@@ -30,7 +30,7 @@ class NotificationTimeoutStorage {
     if (!_fileContent.containsKey(uniqueID)) {
       return DateTime.fromMicrosecondsSinceEpoch(
         0,
-      ); //get 1970 to always trigger notification
+      ); // get 1970 to always trigger notification
     }
     return DateTime.parse(_fileContent[uniqueID] as String);
   }
@@ -51,7 +51,7 @@ class NotificationTimeoutStorage {
     final applicationDirectory =
         (await getApplicationDocumentsDirectory()).path;
     if (!File('$applicationDirectory/notificationTimeout.json').existsSync()) {
-      //empty json
+      // empty json
       await File('$applicationDirectory/notificationTimeout.json')
           .writeAsString('{}');
     }

uni/lib/controller/local_storage/preferences_controller.dart

@@ -283,7 +283,7 @@ class PreferencesController {
     final encrypter = _createEncrypter();
     try {
       return encrypter.decrypt64(base64Text, iv: iv);
-    } catch (e) {
+    } catch (_) {
       return null;
     }
   }

uni/lib/controller/parsers/parser_library_occupation.dart

@@ -21,12 +21,12 @@ Future<LibraryOccupation> parseLibraryOccupationFromSheets(
     int max;
     try {
       floor = (jsonDecoded['table']['rows'][i]['c'][0]['v'] as double).toInt();
-    } catch (e) {
+    } catch (err) {
       floor = 0;
     }
     try {
       max = (jsonDecoded['table']['rows'][i]['c'][1]['v'] as double).toInt();
-    } catch (e) {
+    } catch (err) {
       max = 0;
     }
     occupation.addFloor(FloorOccupation(i + 1, floor, max));

uni/lib/controller/parsers/parser_restaurants.dart

@@ -14,7 +14,7 @@ import 'package:uni/model/utils/day_of_week.dart';
 List<Restaurant> getRestaurantsFromHtml(Response response) {
   final document = parse(response.body);
 
-  //Get restaurant reference number and name
+  // Get restaurant reference number and name
   final restaurantsHtml = document.querySelectorAll('#conteudoinner ul li > a');
 
   final restaurantsTuple = restaurantsHtml.map((restaurantHtml) {
@@ -23,7 +23,7 @@ List<Restaurant> getRestaurantsFromHtml(Response response) {
     return Tuple2(ref ?? '', name);
   }).toList();
 
-  //Get restaurant meals and create the Restaurant class
+  // Get restaurant meals and create the Restaurant class
   final restaurants = restaurantsTuple.map((restaurantTuple) {
     final meals = <Meal>[];
 
@@ -35,14 +35,14 @@ List<Restaurant> getRestaurantsFromHtml(Response response) {
     while (next != null && next.attributes['name'] == null) {
       next = next.nextElementSibling;
       if (next!.classes.contains('dados')) {
-        //It's the menu table
+        // It's the menu table
         final rows = next.querySelectorAll('tr');
-        //Check if is empty
+        // Check if is empty
         if (rows.length <= 1) {
           break;
         }
 
-        //Read rows, first row is ignored because it's the header
+        // Read rows, first row is ignored because it's the header
         rows.getRange(1, rows.length).forEach((row) {
           DayOfWeek? dayOfWeek;
           String? type;
@@ -55,7 +55,7 @@ List<Restaurant> getRestaurantsFromHtml(Response response) {
             if (header == 'Data') {
               final d = parseDayOfWeek(value);
               if (d == null) {
-                //It's a date
+                // It's a date
                 date = format.parseUtc(value);
               } else {
                 dayOfWeek = d;

uni/lib/controller/parsers/parser_schedule_html.dart

@@ -82,7 +82,7 @@ Future<List<Lecture>> getOverlappedClasses(
             )
             .first,
       );
-    } catch (e) {
+    } catch (_) {
       final lect = Lecture.fromHtml(
         subject!,
         typeClass!,

uni/lib/model/entities/calendar_event.dart

@@ -24,7 +24,7 @@ class CalendarEvent {
     try {
       return DateFormat('dd MMMM yyyy', 'pt')
           .parse('${splitDate[0]} $month ${splitDate.last}');
-    } catch (e) {
+    } catch (_) {
       return null;
     }
   }

uni/lib/model/providers/startup/session_provider.dart

@@ -76,7 +76,7 @@ class SessionProvider extends StateProviderNotifier<Session> {
         persistentSession: persistentSession,
         ignoreCached: true,
       );
-    } catch (e) {
+    } catch (_) {
       throw InternetStatusException(locale);
     }
 

uni/lib/model/providers/state_provider_notifier.dart

@@ -81,10 +81,9 @@ abstract class StateProviderNotifier<T> extends ChangeNotifier {
 
     try {
       setState(await loadFromStorage(StateProviders.fromContext(context)));
-    } catch (e, stackTrace) {
-      await Sentry.captureException(e, stackTrace: stackTrace);
-      Logger()
-          .e('Failed to load $runtimeType info from storage: $e\n$stackTrace');
+    } catch (err, st) {
+      await Sentry.captureException(err, stackTrace: st);
+      Logger().e('Failed to load $runtimeType info from storage: $err\n$st');
       _updateStatus(RequestStatus.failed);
     }
 
@@ -135,10 +134,9 @@ abstract class StateProviderNotifier<T> extends ChangeNotifier {
       );
 
       _updateStatus(RequestStatus.successful);
-    } catch (e, stackTrace) {
-      await Sentry.captureException(e, stackTrace: stackTrace);
-      Logger()
-          .e('Failed to load $runtimeType info from remote: $e\n$stackTrace');
+    } catch (err, st) {
+      await Sentry.captureException(err, stackTrace: st);
+      Logger().e('Failed to load $runtimeType info from remote: $err\n$st');
       _updateStatus(RequestStatus.failed);
     }
   }

uni/lib/view/academic_path/widgets/course_units_card.dart

@@ -58,13 +58,9 @@ class CourseUnitsCard extends GenericCard {
     return Column(
       children: courseUnits
           .map(
-            (courseUnit) => Column(
-              children: [
-                Padding(
-                  padding: const EdgeInsets.all(5),
-                  child: CourseUnitCard(courseUnit),
-                ),
-              ],
+            (courseUnit) => Padding(
+              padding: const EdgeInsets.all(5),
+              child: CourseUnitCard(courseUnit),
             ),
           )
           .toList(),

uni/lib/view/bug_report/widgets/form.dart

@@ -262,9 +262,9 @@ class BugReportFormState extends State<BugReportForm> {
         toastMsg = s.success;
       }
       status = true;
-    } catch (e, stackTrace) {
-      await Sentry.captureException(e, stackTrace: stackTrace);
-      Logger().e('Error while posting bug report:$e');
+    } catch (err, st) {
+      await Sentry.captureException(err, stackTrace: st);
+      Logger().e('Error while posting bug report:$err');
       if (context.mounted) {
         toastMsg = s.sent_error;
       }

uni/lib/view/bus_stop_next_arrivals/bus_stop_next_arrivals.dart

@@ -63,18 +63,14 @@ class BusStopNextArrivalsPageState
                     color: Theme.of(context).colorScheme.primary,
                   ),
                 ),
-                Column(
-                  children: [
-                    ElevatedButton(
-                      onPressed: () => Navigator.push(
-                        context,
-                        MaterialPageRoute<BusStopNextArrivalsPage>(
-                          builder: (context) => const BusStopSelectionPage(),
-                        ),
-                      ),
-                      child: Text(S.of(context).add),
+                ElevatedButton(
+                  onPressed: () => Navigator.push(
+                    context,
+                    MaterialPageRoute<BusStopNextArrivalsPage>(
+                      builder: (context) => const BusStopSelectionPage(),
                     ),
-                  ],
+                  ),
+                  child: Text(S.of(context).add),
                 ),
               ],
             ),
@@ -175,22 +171,18 @@ class NextArrivalsState extends State<NextArrivals> {
 
     widget.buses.forEach((stopCode, stopData) {
       rows.add(
-        Column(
-          children: <Widget>[
-            Container(
-              padding: const EdgeInsets.only(
-                top: 8,
-                bottom: 8,
-                left: 22,
-                right: 22,
-              ),
-              child: BusStopRow(
-                stopCode: stopCode,
-                trips: widget.buses[stopCode]?.trips ?? [],
-                stopCodeShow: false,
-              ),
-            ),
-          ],
+        Container(
+          padding: const EdgeInsets.only(
+            top: 8,
+            bottom: 8,
+            left: 22,
+            right: 22,
+          ),
+          child: BusStopRow(
+            stopCode: stopCode,
+            trips: widget.buses[stopCode]?.trips ?? [],
+            stopCodeShow: false,
+          ),
         ),
       );
     });

uni/lib/view/bus_stop_selection/widgets/bus_stop_search.dart

@@ -40,7 +40,7 @@ class BusStopSearch extends SearchDelegate<String> {
 
   @override
   Widget buildLeading(BuildContext context) {
-    //Back arrow to go back to menu
+    // Back arrow to go back to menu
 
     return IconButton(
       icon: const Icon(Icons.arrow_back),