Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redesigning academic page #1151

Merged
merged 21 commits into from
Jul 13, 2024
Merged

Redesigning academic page #1151

merged 21 commits into from
Jul 13, 2024

Conversation

DGoiana
Copy link
Collaborator

@DGoiana DGoiana commented Feb 21, 2024

Closes #877

Review checklist

  • Terms and conditions reflect the current change
  • Contains enough appropriate tests
  • If aimed at production, writes a new summary in whatsnew/whatsnew-pt-PT
  • Properly adds an entry in changelog.md with the change
  • If PR includes UI updates/additions, its description has screenshots
  • Behavior is as expected
  • Clean, well-structured code

@DGoiana DGoiana changed the title Sigarra academic path api Redesigning academic page Mar 10, 2024
@DGoiana
Copy link
Collaborator Author

DGoiana commented Mar 10, 2024

Current design:

@DGoiana
Copy link
Collaborator Author

DGoiana commented Mar 19, 2024

Current page design. Still missing books in the bottom and final thoughts on the regents scroll

Screenshot 2024-03-19 at 16 28 58 Screenshot 2024-03-19 at 16 29 07

Copy link
Collaborator

@bdmendes bdmendes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Notes from the meeting:

  • Make the regents list vertical
  • Expand (for now) the teachers list and show their names

@bdmendes bdmendes added this to the July 2024 Release milestone May 22, 2024
@DGoiana DGoiana mentioned this pull request Jun 19, 2024
7 tasks
@DGoiana DGoiana requested review from thePeras and LuisDuarte1 July 6, 2024 15:56
@thePeras thePeras force-pushed the enhancement/academic-path-api branch from a4beae5 to f63eb68 Compare July 9, 2024 11:02
Copy link
Member

@thePeras thePeras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ 🛫

@thePeras thePeras force-pushed the enhancement/academic-path-api branch from f63eb68 to b0a8403 Compare July 9, 2024 13:43
Copy link

codecov bot commented Jul 9, 2024

Codecov Report

Attention: Patch coverage is 0% with 181 lines in your changes missing coverage. Please review.

Project coverage is 16%. Comparing base (b0e3a6c) to head (aed0bfc).
Report is 2 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #1151    +/-   ##
========================================
- Coverage       16%     16%    -0%     
========================================
  Files          229     233     +4     
  Lines         7161    7293   +132     
========================================
  Hits          1139    1139            
- Misses        6022    6154   +132     

@thePeras thePeras requested a review from a team July 10, 2024 14:34
@DGoiana DGoiana merged commit 7007b32 into develop Jul 13, 2024
6 checks passed
@DGoiana DGoiana deleted the enhancement/academic-path-api branch July 13, 2024 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use SIGARRA Academic Path API to fetch all user course units' contents
4 participants