Fix concurrency issue on deploy action #1187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This occurs when there are too many PRs merged in a 10-minute window. To avoid this, we set a concurrency group per branch (in this case only develop and master apply). I feel like that cancelling the previous deploy actions makes the merged PR less semantic because we technically loose track of where the hotfixes happened.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1187 +/- ##
======================================
Coverage 16% 16%
======================================
Files 229 229
Lines 6957 6957
======================================
Hits 1086 1086
Misses 5871 5871 |
limwa
approved these changes
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This occurs when there are too many PRs merged in a 10-minute window. To avoid this, we set a concurrency group per branch (in this case only develop and master apply). I feel like canceling the previous deploy actions makes the merged PR less semantic because we technically lose track of where the hotfixes happened.