Path exception error while trying to delete cached files

[DGoiana]

Closes #1177

Review checklist

• Terms and conditions reflect the current change
• Contains enough appropriate tests
• If aimed at production, writes a new summary in whatsnew/whatsnew-pt-PT
• Properly adds an entry in changelog.md with the change
• If PR includes UI updates/additions, its description has screenshots
• Behavior is as expected
• Clean, well-structured code

[codecov]

Codecov Report

Merging #1194 (ee0fec0) into master (be1c3ae) will increase coverage by 1%.
Report is 2 commits behind head on master.
The diff coverage is 0%.

Additional details and impacted files

@@          Coverage Diff           @@
##           master   #1194   +/-   ##
======================================
+ Coverage      17%     17%   +1%     
======================================
  Files         229     229           
  Lines        6974    6970    -4     
======================================
  Hits         1144    1144           
+ Misses       5830    5826    -4     

[limwa]

I've written some suggestions for the deletion. Do we need to also delete the folders? Here, I've ignored the folders and focused on only deleting files, since taking care of folders is much more complicated (folders need to be deleted with recursive true, unless they are empty).

Either way, really good work here and thanks for being so quick!

[limwa]

Something else that just popped into my mind is that the database connections need to be closed before the corresponding database files are deleted (if you want, you don't even need to call the deleteLectures, ... methods because the files will be deleted afterwards anyways!). You would need to ensure that no connection can be opened while the file deletion is ongoing.

Another way is to not close the database connections and not delete the database files (for instance, not deleting files that end in .db, or something else)

Which one do you prefer?

[DGoiana]

Something else that just popped into my mind is that the database connections need to be closed before the corresponding database files are deleted (if you want, you don't even need to call the deleteLectures, ... methods because the files will be deleted afterwards anyways!). You would need to ensure that no connection can be opened while the file deletion is ongoing.

Another way is to not close the database connections and not delete the database files (for instance, not deleting files that end in .db, or something else)

Which one do you prefer?

I am avoiding the deletion of .db files to not force any connection lock to the databases.

[limwa]

Sounds good! I'll review this PR later today!

[limwa]

Well done! 🚀