-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor/database #1220
Refactor/database #1220
Conversation
… persistent logic
@vitormpp is this ready? |
fef984a
to
728982d
Compare
@vitormpp Could you rebase/merge with the master branch? I could then try to help you debug it. |
193736e
to
82d6052
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1220 +/- ##
=======================================
+ Coverage 17% 17% +1%
=======================================
Files 229 229
Lines 6986 6992 +6
=======================================
+ Hits 1167 1187 +20
+ Misses 5819 5805 -14 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice work! ✅ 🛫
@vitormpp can you resolve this and merge it? |
The review has been taken into account. No further action is required at this time.
The code looks very clean and well-written. Wonderful abstraction here. Nice job! |
Closes #835
Review checklist
whatsnew/whatsnew-pt-PT
changelog.md
with the change