Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added user agent and screen width size to plausible #1240

Merged
merged 1 commit into from
Jun 11, 2024

Conversation

thePeras
Copy link
Member

@thePeras thePeras commented Jun 1, 2024

Closes #1239

Review checklist

  • Terms and conditions reflect the current change
  • Contains enough appropriate tests
  • If aimed at production, writes a new summary in whatsnew/whatsnew-pt-PT
  • Properly adds an entry in changelog.md with the change
  • If PR includes UI updates/additions, its description has screenshots
  • Behavior is as expected
  • Clean, well-structured code

Copy link
Member

@limwa limwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done! Looks good to me!

@limwa
Copy link
Member

limwa commented Jun 1, 2024

@LuisDuarte1 @DGoiana do we need to worry about the dependencies bumps?

@thePeras thePeras force-pushed the fix/plausible-device branch from cc99880 to cb22c24 Compare June 1, 2024 11:08
Copy link

codecov bot commented Jun 1, 2024

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 17%. Comparing base (02cd6d2) to head (cb22c24).

Additional details and impacted files
@@           Coverage Diff           @@
##           develop   #1240   +/-   ##
=======================================
- Coverage       17%     17%   -0%     
=======================================
  Files          229     229           
  Lines         6949    6952    +3     
=======================================
- Hits          1154    1152    -2     
- Misses        5795    5800    +5     

@thePeras thePeras requested a review from a team June 3, 2024 14:41
Copy link
Member

@LuisDuarte1 LuisDuarte1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 🚀

@thePeras thePeras merged commit 7e25ca3 into develop Jun 11, 2024
6 checks passed
@thePeras thePeras deleted the fix/plausible-device branch June 11, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Plausible custom User Agent
3 participants