Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New PR template #1248

Draft
wants to merge 3 commits into
base: develop
Choose a base branch
from
Draft

New PR template #1248

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d91f57f
New PR template
thePeras Jun 24, 2024
9e76004
release template
thePeras Jun 26, 2024
d2a488c
pr template .env
thePeras Jul 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .github/PULL_REQUEST_TEMPLATE/release_pr_template.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@


# Review Checklist

- [ ] Writes a summary in `whatsnew/whatsnew-pt-PT` of the new changes
- [ ] Terms and conditions reflect the changes
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Terms and conditions should be updated on every PR, if necessary. The reason is the app will be used by beta testers, which are also subject to the terms and conditions of uni.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it can be a little annoying and pushing the responsibility to the person who made the release and its reviews, will allow taking a preoccupation from each PR

25 changes: 15 additions & 10 deletions .github/pull_request_template.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,18 @@
[ATTENTION. This is the *Pull Request Template*. Replace the two following lines with the indicated information and delete this one. Do not delete anything else]

Closes #[issue number]
[Description of the changes proposed in the pull request. Include steps to replicate the behavior and screenshots if UI is updated]
<!--
Description of the changes proposed in the pull request.
Include steps to replicate the behavior and screenshots if UI is updated.
If this is release PR select it's template by adding ?template=release_pr_template.md to the url.
-->

# Review checklist
- [ ] Terms and conditions reflect the current change
- [ ] Contains enough appropriate tests
- [ ] If aimed at production, writes a new summary in `whatsnew/whatsnew-pt-PT`
- [ ] Properly adds an entry in `changelog.md` with the change
- [ ] If PR includes UI updates/additions, its description has screenshots
- [ ] Behavior is as expected
- [ ] Clean, well-structured code

## View Changes

- [ ] Tested both in light and dark mode
- [ ] Description has screenshots of the UI changes
- [ ] Text is both in portuguese and english.

## Documentation

- [ ] Properly adds an entry in `changelog.md` with the change