Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed profile pic and added an horizontal line to some pages #1294

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from

Conversation

clarapbsousa
Copy link
Contributor

Closes #1268
The rightButton has been removed from home.dart, general.dart, and secondary.dart. Additionally, top_navigation_bar.dart has been updated to include an optional horizontal line below the title for pages titled "Faculty" or "Restaurants".

Review checklist

  • Terms and conditions reflect the current change
  • Contains enough appropriate tests
  • If aimed at production, writes a new summary in whatsnew/whatsnew-pt-PT
  • Properly adds an entry in changelog.md with the change
  • If PR includes UI updates/additions, its description has screenshots
  • Behavior is as expected
  • Clean, well-structured code

Imagem de 07-08-24 à(s) 12 06
Imagem de 07-08-24 à(s) 12 05
Imagem de 07-08-24 à(s) 12 05 (1)

Copy link

codecov bot commented Aug 14, 2024

Codecov Report

Attention: Patch coverage is 84.21053% with 3 lines in your changes missing coverage. Please review.

Project coverage is 11%. Comparing base (00bff18) to head (99c1b4d).
Report is 126 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #1294    +/-   ##
========================================
- Coverage       16%     11%    -4%     
========================================
  Files          233     268    +35     
  Lines         7214    7338   +124     
========================================
- Hits          1139     803   -336     
- Misses        6075    6535   +460     

@DGoiana
Copy link
Collaborator

DGoiana commented Aug 20, 2024

Looks good! To finalize, can we just give a little bit of opacity to the line, I think it is too dark.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

General page minor changes
2 participants