Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding new library api #1318

Merged
merged 5 commits into from
Sep 12, 2024
Merged

Adding new library api #1318

merged 5 commits into from
Sep 12, 2024

Conversation

DGoiana
Copy link
Collaborator

@DGoiana DGoiana commented Sep 10, 2024

Closes #1317

Implementation of the new and fresh library occupation api.
As the api does not retrieve data about the capacity of each floor, it was manually inserted into a map.

Review checklist

  • Terms and conditions reflect the current change
  • Contains enough appropriate tests
  • If aimed at production, writes a new summary in whatsnew/whatsnew-pt-PT
  • Properly adds an entry in changelog.md with the change
  • If PR includes UI updates/additions, its description has screenshots
  • Behavior is as expected
  • Clean, well-structured code

@DGoiana DGoiana changed the title adding new library api Adding new library api Sep 10, 2024
Copy link

codecov bot commented Sep 10, 2024

Codecov Report

Attention: Patch coverage is 0% with 17 lines in your changes missing coverage. Please review.

Project coverage is 16%. Comparing base (fa3f3be) to head (452a6c4).
Report is 8 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff           @@
##           develop   #1318   +/-   ##
=======================================
  Coverage       16%     16%           
=======================================
  Files          239     238    -1     
  Lines         7172    7172           
=======================================
  Hits          1078    1078           
  Misses        6094    6094           

@DGoiana DGoiana requested a review from a team September 10, 2024 22:52
@DGoiana DGoiana merged commit f6e0da3 into develop Sep 12, 2024
6 checks passed
@DGoiana DGoiana deleted the feature/new-library-api branch September 12, 2024 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement new library occupation api
3 participants