Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: error when there is no unit bibliography #1323

Merged
merged 1 commit into from
Sep 13, 2024

Conversation

limwa
Copy link
Member

@limwa limwa commented Sep 13, 2024

This PR fixes an issue where fetching a curricular unit's details fails when there is no bibliography on SIGARRA for the unit.

Review checklist

  • Terms and conditions reflect the current change
  • Contains enough appropriate tests
  • If aimed at production, writes a new summary in whatsnew/whatsnew-pt-PT
  • Properly adds an entry in changelog.md with the change
  • If PR includes UI updates/additions, its description has screenshots
  • Behavior is as expected
  • Clean, well-structured code

Copy link

codecov bot commented Sep 13, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 11%. Comparing base (3909b97) to head (e0d8d97).
Report is 7 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff           @@
##           develop   #1323   +/-   ##
=======================================
+ Coverage       11%     11%   +1%     
=======================================
  Files          268     268           
  Lines         7303    7302    -1     
=======================================
  Hits           799     799           
+ Misses        6504    6503    -1     

@limwa limwa requested a review from thePeras September 13, 2024 22:50
@DGoiana DGoiana merged commit 0d7dbde into develop Sep 13, 2024
6 checks passed
@DGoiana DGoiana deleted the limwa/fix/bibliography-invalid-cast branch September 13, 2024 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants