-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor/lazy provider #823
Conversation
c3da4df
to
a3de86f
Compare
a3de86f
to
1d13aa3
Compare
63b25e4
to
a231d07
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Congratulations! 🥳 This one is a tough one and you managed it super well 😃 with no visible regressions that I can test. I just have some concerns below related more to maintainability and knowing how some parts of the system works
0564e6f
to
8142b3f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, good work! 🚀 🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only thing I don't agree with is when using a non-persistent session the homepage loads with no widgets, not even the default ones (Is this intentional?).
Otherwise good job, a great refactor, both in size and quality.
@LuisDuarte1 @Sirze01 I have opted to always load from storage, even if the session is not persistent, to generalize the loading and avoid bugs like the one @Sirze01 found. To make sure data does not get loaded into storage when the session is not persistent, I suggest tackling #835 in another PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's great now. Working as expected
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! nice catch 🎉
Closes #659
This PR:
LazyConsumer
is used to replaceConsumer
.RequestDependantWidgetBuilder
to make loading status more consistentPlease review this carefully as this changes the main flow of the app.
Review checklist
whatsnew/whatsnew-pt-PT
changelog.md
with the change