Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No prediction methods for full models #42

Closed
ericbair-sciome opened this issue Dec 23, 2023 · 1 comment
Closed

No prediction methods for full models #42

ericbair-sciome opened this issue Dec 23, 2023 · 1 comment
Labels
enhancement New feature or request future research Future research is needed to determine if this feature should be implemented version ? Uncertain when this feature will be implemented

Comments

@ericbair-sciome
Copy link
Collaborator

As I reviewed the old code, I noticed that there are no prediction methods for full models. I think it would be worth creating prediction methods for these models at some point, although I am not sure how difficult this will be to do.
@ericbair-sciome ericbair-sciome added enhancement New feature or request version ? Uncertain when this feature will be implemented future research Future research is needed to determine if this feature should be implemented labels Dec 23, 2023
@kyle-messier
Copy link
Collaborator

@ericbair-sciome Full model, as in no Vecchia? I think a working method for non-Vecchia would be good to have. We can base it off the previous LURK-Vecchia code, but I guess it would take some significant work to get it into the methods exporting style you are using here

sciome-bot pushed a commit that referenced this issue Apr 9, 2024
@shail-choksi
Pull request #43: Fix documentation issue blocking R CMD check and re…
6c79863 
…vert execute permission on all files

Squashed commit of the following:

commit 00171d7
Merge: cb9236b e0c9039
Author: Shail Choksi <shail.choksi@sciome.com>
Date:   Tue Apr 9 17:17:39 2024 -0400

    Pull request #44: Revert execute permissions on all files

    Merge in STAT/prestogp from shail-dev-2 to master

    * commit 'e0c90391f290dd2f6ebe62f6a69db8ec006c1872':
      chmod changes
      Implement imputation beta

commit e0c9039
Merge: b8f91fd 05e7dfb
Author: sciome-bot <software.tools@sciome.com>
Date:   Tue Apr 9 17:16:29 2024 -0400

    Merge branch 'to-git' of ssh://sciome-bot/stat/prestogp into shail-dev-2

commit b8f91fd
Author: sciome-bot <software.tools@sciome.com>
Date:   Tue Apr 9 17:10:53 2024 -0400

    chmod changes

commit cb9236b
Merge: cae8439 218a18a
Author: Eric Bair <eric.bair@sciome.com>
Date:   Tue Apr 9 17:03:10 2024 -0400

    Pull request #42: Fixed a documentation issue

    Merge in STAT/prestogp from eb-dev to master

    * commit '218a18a6cd2891c7c4975e408f7308243c11abbf':
      Fixed a documentation issue

commit 218a18a
Author: Eric Bair <eric.bair@sciome.com>
Date:   Mon Apr 8 02:18:24 2024 -0400

    Fixed a documentation issue

commit cae8439
Merge: c15c519 6bafe5c
Author: Eric Bair <eric.bair@sciome.com>
Date:   Fri Apr 5 16:38:34 2024 -0400

    Pull request #40: Imputation beta

    Merge in STAT/prestogp from eb-dev to master

    * commit '6bafe5cf9d5574074bdcb0288e4b48efb87a8840':
      Imputation beta implemented
      Updated version number

commit 6bafe5c
Author: Eric Bair <eric.bair@sciome.com>
Date:   Thu Apr 4 00:17:45 2024 -0400

    Imputation beta implemented

commit 1f4bcc7
Author: Eric Bair <eric.bair@sciome.com>
Date:   Sun Mar 17 16:36:13 2024 -0400

    Updated version number

commit c15c519
Merge: 350b236 bab8357
Author: sciome-bot <software.tools@sciome.com>
Date:   Thu Feb 8 14:25:12 2024 -0500

    Merge branch 'master' of ssh://sciome-bot/stat/prestogp

commit 350b236
Merge: 55c0e8e 95fef8c
Author: sciome-bot <software.tools@sciome.com>
Date:   Thu Feb 8 14:24:34 2024 -0500

    Merge branch 'main-sciome' of sciome-bot-git:Spatiotemporal-Exposures-and-Toxicology/PrestoGP

commit bab8357
Merge: 55c0e8e 5394772
Author: Eric Bair <eric.bair@sciome.com>
Date:   Thu Feb 8 14:19:24 2024 -0500

    Pull request #38: Removed vignette, fixed lint issues

    Merge in STAT/prestogp from eb-dev to master

    * commit '53947729624b47fa1920ef39bd23d86f6e5cd7b7':
      Removed vignette, fixed lint issues

commit 55c0e8e
Merge: 7e330f3 076c0a1
Author: sciome-bot <software.tools@sciome.com>
Date:   Thu Feb 8 14:18:48 2024 -0500

    Merge branch 'main-sciome' of sciome-bot-git:Spatiotemporal-Exposures-and-Toxicology/PrestoGP

commit 5394772
Merge: b431df4 7e330f3
Author: Eric Bair <eric.bair@sciome.com>
Date:   Thu Feb 8 14:07:54 2024 -0500

    Resolved merge conflict

commit b431df4
Author: Eric Bair <eric.bair@sciome.com>
Date:   Thu Feb 8 13:56:38 2024 -0500

    Removed vignette, fixed lint issues

commit 7e330f3
Merge: 13a6f44 f49d076
Author: sciome-bot <software.tools@sciome.com>
Date:   Wed Feb 7 23:25:05 2024 -0500

    Merge branch 'master' of ssh://sciome-bot/stat/prestogp

commit f49d076
Merge: 439790c 59baf72
Author: Eric Bair <eric.bair@sciome.com>
Date:   Wed Feb 7 23:19:54 2024 -0500

    Pull request #35: Eb dev

    Merge in STAT/prestogp from eb-dev to master

    * commit '59baf720737abe59a04c98705c950ef1c7b63321':
      Fixed some documentation issues
      Removed C++11 compiler flag
      Added RandomFields data sets to PrestoGP
      Added knitr to Suggests in DESCRIPTION
      Documentation, R-cmd-check fixes, binomial regression

commit 59baf72
Author: Eric Bair <eric.bair@sciome.com>
Date:   Tue Feb 6 17:49:48 2024 -0500

    Fixed some documentation issues

commit d857d8b
Author: Eric Bair <eric.bair@sciome.com>
Date:   Thu Feb 1 02:16:44 2024 -0500

    Removed C++11 compiler flag

commit 662907d
Author: Eric Bair <eric.bair@sciome.com>
Date:   Wed Jan 31 15:36:37 2024 -0500

    Added RandomFields data sets to PrestoGP

commit cf2aadb
Author: Eric Bair <eric.bair@sciome.com>
Date:   Wed Jan 31 13:40:24 2024 -0500

    Added knitr to Suggests in DESCRIPTION

... and 35 more commits
sciome-bot pushed a commit that referenced this issue Apr 25, 2024
@shail-choksi
Remove dependency on sysreqs to fix sanitizer action
d1dd01b 
Squashed commit of the following:

commit 4aa13ad
Author: sciome-bot <software.tools@sciome.com>
Date:   Wed Apr 24 20:16:19 2024 -0400

    Remove dependency on sysreqs to fix sanitizer action.

commit 7fad5a6
Merge: 3f3c9e3 df836b7
Author: sciome-bot <software.tools@sciome.com>
Date:   Wed Apr 24 20:12:09 2024 -0400

    Merge branch 'main-sciome' of sciome-bot-git:NIEHS/PrestoGP

commit 3f3c9e3
Author: Eric Bair <eric.bair@sciome.com>
Date:   Wed Apr 24 17:17:41 2024 -0400

    Observation-level lod, imputation tests, updated README

    Squashed commit of the following:

    commit 9dfcef3
    Merge: 33b0560 68671e6
    Author: Eric Bair <eric.bair@sciome.com>
    Date:   Tue Apr 23 16:41:15 2024 -0400

        Merge branch 'master' of http://192.168.167.103:7990/bitbucket/scm/stat/prestogp into eb-dev

        Conflicts:
        	README.md

    commit 33b0560
    Author: Eric Bair <eric.bair@sciome.com>
    Date:   Tue Apr 23 03:05:12 2024 -0400

        Observation-level lod, imputation tests, updated README

commit 68671e6
Merge: 00171d7 7fe8997
Author: sciome-bot <software.tools@sciome.com>
Date:   Wed Apr 10 09:51:12 2024 -0400

    Merge branch 'main-sciome' of sciome-bot-git:NIEHS/PrestoGP

commit 00171d7
Merge: cb9236b e0c9039
Author: Shail Choksi <shail.choksi@sciome.com>
Date:   Tue Apr 9 17:17:39 2024 -0400

    Pull request #44: Revert execute permissions on all files

    Merge in STAT/prestogp from shail-dev-2 to master

    * commit 'e0c90391f290dd2f6ebe62f6a69db8ec006c1872':
      chmod changes
      Implement imputation beta

commit e0c9039
Merge: b8f91fd 05e7dfb
Author: sciome-bot <software.tools@sciome.com>
Date:   Tue Apr 9 17:16:29 2024 -0400

    Merge branch 'to-git' of ssh://sciome-bot/stat/prestogp into shail-dev-2

commit b8f91fd
Author: sciome-bot <software.tools@sciome.com>
Date:   Tue Apr 9 17:10:53 2024 -0400

    chmod changes

commit cb9236b
Merge: cae8439 218a18a
Author: Eric Bair <eric.bair@sciome.com>
Date:   Tue Apr 9 17:03:10 2024 -0400

    Pull request #42: Fixed a documentation issue

    Merge in STAT/prestogp from eb-dev to master

    * commit '218a18a6cd2891c7c4975e408f7308243c11abbf':
      Fixed a documentation issue

commit 218a18a
Author: Eric Bair <eric.bair@sciome.com>
Date:   Mon Apr 8 02:18:24 2024 -0400

    Fixed a documentation issue

commit cae8439
Merge: c15c519 6bafe5c
Author: Eric Bair <eric.bair@sciome.com>
Date:   Fri Apr 5 16:38:34 2024 -0400

    Pull request #40: Imputation beta

    Merge in STAT/prestogp from eb-dev to master

    * commit '6bafe5cf9d5574074bdcb0288e4b48efb87a8840':
      Imputation beta implemented
      Updated version number

commit 6bafe5c
Author: Eric Bair <eric.bair@sciome.com>
Date:   Thu Apr 4 00:17:45 2024 -0400

    Imputation beta implemented

commit 1f4bcc7
Author: Eric Bair <eric.bair@sciome.com>
Date:   Sun Mar 17 16:36:13 2024 -0400

    Updated version number

commit c15c519
Merge: 350b236 bab8357
Author: sciome-bot <software.tools@sciome.com>
Date:   Thu Feb 8 14:25:12 2024 -0500

    Merge branch 'master' of ssh://sciome-bot/stat/prestogp

commit 350b236
Merge: 55c0e8e 95fef8c
Author: sciome-bot <software.tools@sciome.com>
Date:   Thu Feb 8 14:24:34 2024 -0500

    Merge branch 'main-sciome' of sciome-bot-git:Spatiotemporal-Exposures-and-Toxicology/PrestoGP

commit bab8357
Merge: 55c0e8e 5394772
Author: Eric Bair <eric.bair@sciome.com>
Date:   Thu Feb 8 14:19:24 2024 -0500

    Pull request #38: Removed vignette, fixed lint issues

    Merge in STAT/prestogp from eb-dev to master

    * commit '53947729624b47fa1920ef39bd23d86f6e5cd7b7':
      Removed vignette, fixed lint issues

commit 55c0e8e
Merge: 7e330f3 076c0a1
Author: sciome-bot <software.tools@sciome.com>
Date:   Thu Feb 8 14:18:48 2024 -0500

    Merge branch 'main-sciome' of sciome-bot-git:Spatiotemporal-Exposures-and-Toxicology/PrestoGP

commit 5394772
Merge: b431df4 7e330f3
Author: Eric Bair <eric.bair@sciome.com>
Date:   Thu Feb 8 14:07:54 2024 -0500

    Resolved merge conflict

commit b431df4
Author: Eric Bair <eric.bair@sciome.com>
Date:   Thu Feb 8 13:56:38 2024 -0500

    Removed vignette, fixed lint issues

commit 7e330f3
Merge: 13a6f44 f49d076
Author: sciome-bot <software.tools@sciome.com>
Date:   Wed Feb 7 23:25:05 2024 -0500

    Merge branch 'master' of ssh://sciome-bot/stat/prestogp

commit f49d076
Merge: 439790c 59baf72
Author: Eric Bair <eric.bair@sciome.com>
Date:   Wed Feb 7 23:19:54 2024 -0500

    Pull request #35: Eb dev

    Merge in STAT/prestogp from eb-dev to master

    * commit '59baf720737abe59a04c98705c950ef1c7b63321':
      Fixed some documentation issues
      Removed C++11 compiler flag
      Added RandomFields data sets to PrestoGP
      Added knitr to Suggests in DESCRIPTION
      Documentation, R-cmd-check fixes, binomial regression

... and 37 more commits
sciome-bot added a commit that referenced this issue Apr 26, 2024
@sciome-bot
Removed the spam dependency to fix an R CMD check issue
3f9df3e 
Squashed commit of the following:

commit aa730b5
Merge: 4aa13ad d596c46
Author: Eric Bair <eric.bair@sciome.com>
Date:   Fri Apr 26 14:26:42 2024 -0400

    Pull request #48: Eb dev

    Merge in STAT/prestogp from eb-dev to master

    * commit 'd596c46f0d84704329b02cdf39f419e1ee9f626b':
      Fixed file permissions
      Removed the spam dependency to fix an R CMD check issue
      Observation-level lod, imputation tests, updated README

commit d596c46
Author: Eric Bair <eric.bair@sciome.com>
Date:   Fri Apr 26 14:05:23 2024 -0400

    Fixed file permissions

commit 6543908
Merge: 86bdd92 4aa13ad
Author: Eric Bair <eric.bair@sciome.com>
Date:   Thu Apr 25 18:19:08 2024 -0400

    Fixed a merge conflict

commit 86bdd92
Author: Eric Bair <eric.bair@sciome.com>
Date:   Thu Apr 25 18:11:04 2024 -0400

    Removed the spam dependency to fix an R CMD check issue

commit 4aa13ad
Author: sciome-bot <software.tools@sciome.com>
Date:   Wed Apr 24 20:16:19 2024 -0400

    Remove dependency on sysreqs to fix sanitizer action.

commit 7fad5a6
Merge: 3f3c9e3 df836b7
Author: sciome-bot <software.tools@sciome.com>
Date:   Wed Apr 24 20:12:09 2024 -0400

    Merge branch 'main-sciome' of sciome-bot-git:NIEHS/PrestoGP

commit 3f3c9e3
Author: Eric Bair <eric.bair@sciome.com>
Date:   Wed Apr 24 17:17:41 2024 -0400

    Observation-level lod, imputation tests, updated README

    Squashed commit of the following:

    commit 9dfcef3
    Merge: 33b0560 68671e6
    Author: Eric Bair <eric.bair@sciome.com>
    Date:   Tue Apr 23 16:41:15 2024 -0400

        Merge branch 'master' of http://192.168.167.103:7990/bitbucket/scm/stat/prestogp into eb-dev

        Conflicts:
        	README.md

    commit 33b0560
    Author: Eric Bair <eric.bair@sciome.com>
    Date:   Tue Apr 23 03:05:12 2024 -0400

        Observation-level lod, imputation tests, updated README

commit 9dfcef3
Merge: 33b0560 68671e6
Author: Eric Bair <eric.bair@sciome.com>
Date:   Tue Apr 23 16:41:15 2024 -0400

    Merge branch 'master' of http://192.168.167.103:7990/bitbucket/scm/stat/prestogp into eb-dev

    Conflicts:
    	README.md

commit 33b0560
Author: Eric Bair <eric.bair@sciome.com>
Date:   Tue Apr 23 03:05:12 2024 -0400

    Observation-level lod, imputation tests, updated README

commit 68671e6
Merge: 00171d7 7fe8997
Author: sciome-bot <software.tools@sciome.com>
Date:   Wed Apr 10 09:51:12 2024 -0400

    Merge branch 'main-sciome' of sciome-bot-git:NIEHS/PrestoGP

commit 00171d7
Merge: cb9236b e0c9039
Author: Shail Choksi <shail.choksi@sciome.com>
Date:   Tue Apr 9 17:17:39 2024 -0400

    Pull request #44: Revert execute permissions on all files

    Merge in STAT/prestogp from shail-dev-2 to master

    * commit 'e0c90391f290dd2f6ebe62f6a69db8ec006c1872':
      chmod changes
      Implement imputation beta

commit e0c9039
Merge: b8f91fd 05e7dfb
Author: sciome-bot <software.tools@sciome.com>
Date:   Tue Apr 9 17:16:29 2024 -0400

    Merge branch 'to-git' of ssh://sciome-bot/stat/prestogp into shail-dev-2

commit b8f91fd
Author: sciome-bot <software.tools@sciome.com>
Date:   Tue Apr 9 17:10:53 2024 -0400

    chmod changes

commit cb9236b
Merge: cae8439 218a18a
Author: Eric Bair <eric.bair@sciome.com>
Date:   Tue Apr 9 17:03:10 2024 -0400

    Pull request #42: Fixed a documentation issue

    Merge in STAT/prestogp from eb-dev to master

    * commit '218a18a6cd2891c7c4975e408f7308243c11abbf':
      Fixed a documentation issue

commit 218a18a
Author: Eric Bair <eric.bair@sciome.com>
Date:   Mon Apr 8 02:18:24 2024 -0400

    Fixed a documentation issue

commit cae8439
Merge: c15c519 6bafe5c
Author: Eric Bair <eric.bair@sciome.com>
Date:   Fri Apr 5 16:38:34 2024 -0400

    Pull request #40: Imputation beta

    Merge in STAT/prestogp from eb-dev to master

    * commit '6bafe5cf9d5574074bdcb0288e4b48efb87a8840':
      Imputation beta implemented
      Updated version number

commit 6bafe5c
Author: Eric Bair <eric.bair@sciome.com>
Date:   Thu Apr 4 00:17:45 2024 -0400

    Imputation beta implemented

commit 1f4bcc7
Author: Eric Bair <eric.bair@sciome.com>
Date:   Sun Mar 17 16:36:13 2024 -0400

    Updated version number

commit c15c519
Merge: 350b236 bab8357
Author: sciome-bot <software.tools@sciome.com>
Date:   Thu Feb 8 14:25:12 2024 -0500

    Merge branch 'master' of ssh://sciome-bot/stat/prestogp

commit 350b236
Merge: 55c0e8e 95fef8c
Author: sciome-bot <software.tools@sciome.com>
Date:   Thu Feb 8 14:24:34 2024 -0500

    Merge branch 'main-sciome' of sciome-bot-git:Spatiotemporal-Exposures-and-Toxicology/PrestoGP

... and 43 more commits
sciome-bot pushed a commit that referenced this issue Dec 29, 2024
@ericbair-sciome @shail-choksi
Pull request #42: Fixed a documentation issue
cb9236b 
Merge in STAT/prestogp from eb-dev to master

* commit '218a18a6cd2891c7c4975e408f7308243c11abbf':
  Fixed a documentation issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request future research Future research is needed to determine if this feature should be implemented version ? Uncertain when this feature will be implemented
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kyle-messier @ericbair-sciome