Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: add note class #3

Merged
merged 3 commits into from
May 29, 2024
Merged

style: add note class #3

merged 3 commits into from
May 29, 2024

Conversation

ac-willeke
Copy link
Contributor

Example on how to create styling classes. We could also create different textboxes: .note .warning etc..

@anders-kolstad
Copy link
Collaborator

The checks failed with this erros:

remote: Permission to NINAnor/NINA-ebook-template.git denied to github-actions[bot].
fatal: unable to access 'https://github.com/NINAnor/NINA-ebook-template/': The requested URL returned error: 403

The repo did not give GH actions write permission, which its needs to render the book and add html files.
I think this is set at the NINAnor level, but we can bypass it in the project YAML (_quarto.yml) with this:

permissions:
  contents: read
  pages: write          # <-- Add this line

I have also added a branch protection over the main branch. That could block this again. But I made @ac-willeke admin so you can remove the branch protection if needed.

Also, there was a warning about missing packages:

Warning message:
The downlit and xml2 packages are required for code linking 

R packages can be specified in the DESCRIPTION file.

- write access: repo contents and gh-pages 
- delete pandoc (not necessary)
- install python packages from requirements.txt
- cleaning: delete unnecessary commons give each step a name
@ac-willeke
Copy link
Contributor Author

  • missing R packages are added to DESCRIPTION file
  • permissions for pages set to write in workflow file: quarto-render.yml

Note: workflow runs correctly on the forked repo, but fails while running from NINAnor. This is due to the fact that the NINAnor repo is protected. Forks cannot get write access to the GITHUB_TOKEN and therefore workflow fails on this error:

remote: Permission to NINAnor/NINA-ebook-template.git denied to github-actions[bot].
fatal: unable to access 'https://github.com/NINAnor/NINA-ebook-template/': The requested URL returned error: 403

Info from GitHub docs

Changing the permissions in a forked repository
You can use the permissions key to add and remove read permissions for forked repositories, but typically you can't grant write access. The exception to this behavior is where an admin user has selected the Send write tokens to workflows from pull requests option in the GitHub Actions settings. For more information, see "Managing GitHub Actions settings for a repository."

@ac-willeke ac-willeke merged commit 4c8a95c into NINAnor:main May 29, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants