Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support JSON Logic Validation #471

Merged
merged 9 commits into from
Oct 29, 2024
Merged

Conversation

dxnter
Copy link
Member

@dxnter dxnter commented Oct 29, 2024

Overview

Adding support for JSON Logic into the component validation process.

Fixes

  • Fixed an instance where the $subject parameter to str_replace() could have been null in Textfield::processValidations(), as this was deprecated in PHP 8.1.

Checklist

  • tests/ added or updated
  • CHANGELOG.md's Unreleased section is updated
  • Documentation is updated

Passing null to non-nullable internal function parameters is deprecated in PHP 8.1
@dxnter dxnter requested a review from nie7321 October 29, 2024 17:24
@dxnter dxnter requested a review from a team as a code owner October 29, 2024 17:24
Copy link

Test Results

867 tests  +22   867 ✅ +22   45s ⏱️ +3s
125 suites + 1     0 💤 ± 0 
  1 files   ± 0     0 ❌ ± 0 

Results for commit 82f6129. ± Comparison against base commit 4c574a9.

Copy link

github-actions bot commented Oct 29, 2024

Test Results

894 tests  +49   894 ✅ +49   47s ⏱️ +5s
125 suites + 1     0 💤 ± 0 
  1 files   ± 0     0 ❌ ± 0 

Results for commit c2b7576. ± Comparison against base commit 4c574a9.

♻️ This comment has been updated with latest results.

@coveralls
Copy link

coveralls commented Oct 29, 2024

Coverage Status

coverage: 95.455% (-0.007%) from 95.462%
when pulling c2b7576 on add-advanced-validation-support
into 4c574a9 on develop.

@nie7321 nie7321 merged commit 3827eb7 into develop Oct 29, 2024
5 checks passed
@nie7321 nie7321 deleted the add-advanced-validation-support branch October 29, 2024 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants