-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement mode in backends #207
Conversation
The I do have some comments/questions about the
|
I don't know about I don't think it will always be RGBA with openslideload, this will depend on the image you're loading (in contrast with openslide-python) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe images will be loaded as RGBA when using openslideload, but checking the number of bands in images will also generate the correct results in any case. The changes look good to me.
This implements a
mode
flag in the SlideImage backends. This is required since the ICC profiles need to know what the output type is (e.g. RGB or RGBA). While OpenSlide always returns RGBA, this is not the case for libvips.