Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an optional colormap parameter while writing tiff files. #213

Merged
merged 16 commits into from
Dec 20, 2023

Conversation

AjeyPaiK
Copy link
Member

@AjeyPaiK AjeyPaiK commented Dec 19, 2023

Fixes {#212}

This PR adds an optional colormap tag to this tiff writer which helps us store colors corresponding to index values in case the tiff file being written is a mask. Adding this will allow third party applications such as FIJI, ASAP or Slidescore to automatically apply the color look up table while opening the tiff file. Below are screenshots of viewing a test image in these viewers:

  1. ASAP

image

  1. FIJI

image

  1. slidescore

image

Copy link
Contributor

@jonasteuwen jonasteuwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

dlup/background.py Show resolved Hide resolved
dlup/writers.py Outdated Show resolved Hide resolved
dlup/writers.py Outdated Show resolved Hide resolved
dlup/writers.py Show resolved Hide resolved
tests/test_writers.py Outdated Show resolved Hide resolved
tests/test_writers.py Outdated Show resolved Hide resolved
tests/test_writers.py Show resolved Hide resolved
tests/test_writers.py Show resolved Hide resolved
tests/test_writers.py Outdated Show resolved Hide resolved
@jonasteuwen jonasteuwen added this to the v0.4 milestone Dec 20, 2023
@jonasteuwen jonasteuwen merged commit cb9e084 into main Dec 20, 2023
8 checks passed
@jonasteuwen jonasteuwen deleted the feature/add-colortag-to-tiffwriter branch December 20, 2023 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants