Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename to statsframe #13

Merged
merged 2 commits into from
Jan 25, 2024
Merged

Rename to statsframe #13

merged 2 commits into from
Jan 25, 2024

Conversation

NKeleher
Copy link
Owner

didn't like pydatasummary, but statsframe is available

@NKeleher NKeleher merged commit 081dc62 into main Jan 25, 2024
2 checks passed
@NKeleher NKeleher deleted the rename-to-statsframe branch January 25, 2024 15:26
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Type: Refactoring

PR Summary: The pull request encompasses a project-wide renaming from 'pydatasummary' to 'statsframe'. This includes updates to documentation, example code, configuration files, and internal references within the codebase to reflect the new project name.

Decision: Comment

📝 Type: 'Refactoring' - not supported yet.
  • Sourcery currently only approves 'Typo fix' PRs.
✅ Issue addressed: this change correctly addresses the issue or implements the desired feature.
No details provided.
📝 Complexity: the changes are too large or complex for Sourcery to approve.
  • Unsupported files: the diff contains files that Sourcery does not currently support during reviews.

General suggestions:

  • Ensure that all references to the project, including URLs and any configuration files that might use the project name, are updated to prevent broken links or misconfigurations.
  • Verify that the renaming does not affect the functionality of the code by running all tests and examples to ensure they still work as expected with the new project name.
  • Document the rationale behind significant changes such as the removal of 'pytest-cov' from the 'build' target in the Makefile to maintain clarity for future maintainers.

Thanks for using Sourcery. We offer it for free for open source projects and would be very grateful if you could help us grow. If you like it, would you consider sharing Sourcery on your favourite social media? ✨

Share Sourcery

Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.


build: pytest-cov
build:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue (llm): The removal of the 'pytest-cov' dependency from the 'build' target in the Makefile could lead to a situation where tests are not run before building, potentially allowing bugs to slip into the build. If this change is intentional, consider documenting the rationale behind it to maintain clarity for future maintainers.

@@ -3,7 +3,7 @@ project:
type: website
output-dir: .
# website:
# title: "pydatasummary"
# title: "statsframe"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick (llm): The commented-out configuration in 'docs/_quarto.yml' still references the old project name. If these lines are to be used in the future, they should be updated to reflect the new project name 'statsframe'.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant