ORBIT BOS upgrade for detailed farms#103
Closed
cfrontin wants to merge 69 commits intoNLRWindSystems:developfrom
Closed
ORBIT BOS upgrade for detailed farms#103cfrontin wants to merge 69 commits intoNLRWindSystems:developfrom
cfrontin wants to merge 69 commits intoNLRWindSystems:developfrom
Conversation
* liberate python 3.13 * actually liberate python * update testing * version number inequality fix * walkback python for backdated wisdem * propogate to tests
…shore-development
…shore-development
…shore-development
…shore-development
…shore-development
…Ard into feature/bos-layout-improvement
…shore-development
…ture/bos-layout-improvement
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enhances BOS modeling by integrating the new ORBITDetail component, refines geomorphology error handling and soil parsing, and introduces a skeleton for detailed mooring system design.
- Migrate assertion-based validity checks in
GeomorphologyGridDatato explicit exceptions and expand MoorPy soil file parsing. - Add
ORBITDetailusage with tests and update example scripts to connect substations. - Introduce
DetailedMooringDesigncomponent stub for offshore mooring layouts and register it in__init__.
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| test/unit/ard/geographic/test_geomorphology.py | Updated exception types and added test_load_moorpy_soil tests |
| test/unit/ard/cost/test_orbit_wrap.py | New ORBITDetail unit tests |
| examples/offshore/optimization_demo.py | Switched from wisdem_wrap.ORBIT to orbit_wrap.ORBITDetail and updated connections |
| examples/offshore-detailed/analysis_demo.py | Added full offshore-detailed analysis demo script |
| ard/offshore/mooring_design_detailed.py | Added skeleton for detailed mooring design component |
| ard/offshore/init.py | Registered mooring_design_detailed |
| ard/geographic/geomorphology.py | Replaced asserts with ValueError/TypeError and enhanced soil reader |
Comments suppressed due to low confidence (1)
ard/offshore/mooring_design_detailed.py:11
- The new
DetailedMooringDesigncomponent is unimplemented and has no unit tests. Add tests to cover itscomputelogic once implemented to ensure future reliability.
class DetailedMooringDesign(om.ExplicitComponent):
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Collaborator
Author
|
This has been replaced by #106 because it picked up some extraneous stuff from the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two questions:
Todo: