Skip to content

Conversation

@jaredthomas68
Copy link
Contributor

This PR restricts numpy to less than 2.3, and python to less than 3.13 due to compatibility issues related to numba and numpy as used in optiwindnet.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes compatibility issues with numba and numpy by restricting the supported versions of numpy and Python.

  • Python version is now restricted from 3.10 up to, but not including, 3.13.
  • The numpy dependency is constrained to versions lower than 2.3.
  • The testing workflows have been adjusted to only run tests on Python 3.12.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
pyproject.toml Updated python version and numpy dependency constraints
.github/workflows/python-tests-unit.yml Reduced the test matrix to Python 3.12
.github/workflows/python-tests-system.yml Reduced the test matrix to Python 3.12
Comments suppressed due to low confidence (2)

.github/workflows/python-tests-unit.yml:15

  • Consider including Python 3.10 and 3.11 in the test matrix to fully validate support for the entire Python version range specified in pyproject.toml.
        python-version: [3.12] # ["3.10", "3.11", "3.12", "3.13"]

.github/workflows/python-tests-system.yml:15

  • Consider including Python 3.10 and 3.11 in the test matrix to ensure that all supported versions in requires-python are properly tested.
        python-version: [3.12] # ["3.10", "3.11", "3.12", "3.13"]

Copy link
Collaborator

@cfrontin cfrontin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These look great- let's send an issue in for optiwindnet and tie an issue in Ard to that issue, so we don't lose track of this temporary fix.

@jaredthomas68 jaredthomas68 merged commit 3595653 into NLRWindSystems:develop Jun 23, 2025
7 checks passed
@jaredthomas68 jaredthomas68 deleted the bugfix branch June 23, 2025 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants