-
Notifications
You must be signed in to change notification settings - Fork 31
Opemdao updates #81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Opemdao updates #81
Conversation
| @@ -844,13 +868,14 @@ def compute(self, inputs, outputs, discrete_inputs, discrete_outputs): | |||
| outputs["yaw_period"] = outputs["rigid_body_periods"][5] | |||
|
|
|||
| # Compute some aggregate outputs manually | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This case_mask is required for new WEIS cases that don't run any cases in RAFT. max_nac_accel was just a typo that lingered for too long.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds support for rigid bodies at the OpenMDAO interface for WEIS work. It introduces functionality to configure and handle rigid body parameters in the RAFT modeling framework, while also updating test configurations and dependencies.
- Adds rigid body support with parameters for position, mass, and inertia in the OpenMDAO interface
- Updates test configurations to include rigid body placeholders with default empty values
- Modifies GitHub Actions workflow to always install MoorPy development branch
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/test_omdao_OC3spar.py | Adds empty rigid body configuration structure for test compatibility |
| tests/test_data/weis_options.yaml | Extensive updates to modeling options including rigid body structure and reduced test cases |
| tests/test_data/weis_inputs.yaml | Updates to turbine parameters, platform configuration, and mooring properties |
| raft/omdao_raft.py | Core implementation of rigid body support in OpenMDAO interface |
| .github/workflows/CI_RAFT.yml | Removes conditional logic for MoorPy development branch installation |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
Thanks, Dan! |
Purpose
Support rigid bodies at openmdao interface for WEIS work
Can add mean_load, too.
Type of change
What types of change is it?
Select the appropriate type(s) that describe this PR
Testing
Explain the steps needed to test the new code to verify that it does indeed address the issue and produce the expected behavior.
Checklist
Put an
xin the boxes that apply.