Skip to content

Conversation

@dzalkind
Copy link
Contributor

@dzalkind dzalkind commented Jul 9, 2025

Purpose

Support rigid bodies at openmdao interface for WEIS work

Can add mean_load, too.

Type of change

What types of change is it?
Select the appropriate type(s) that describe this PR

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (non-backwards-compatible fix or feature)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Documentation update
  • Maintenance update
  • Other (please describe)

Testing

Explain the steps needed to test the new code to verify that it does indeed address the issue and produce the expected behavior.

Checklist

Put an x in the boxes that apply.

  • I have run existing tests which pass locally with my changes
  • I have added new tests or examples that prove my fix is effective or that my feature works
  • I have added necessary documentation

@@ -844,13 +868,14 @@ def compute(self, inputs, outputs, discrete_inputs, discrete_outputs):
outputs["yaw_period"] = outputs["rigid_body_periods"][5]

# Compute some aggregate outputs manually
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This case_mask is required for new WEIS cases that don't run any cases in RAFT. max_nac_accel was just a typo that lingered for too long.

@dzalkind dzalkind changed the base branch from rc1.5.0 to struct_dev September 9, 2025 21:35
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for rigid bodies at the OpenMDAO interface for WEIS work. It introduces functionality to configure and handle rigid body parameters in the RAFT modeling framework, while also updating test configurations and dependencies.

  • Adds rigid body support with parameters for position, mass, and inertia in the OpenMDAO interface
  • Updates test configurations to include rigid body placeholders with default empty values
  • Modifies GitHub Actions workflow to always install MoorPy development branch

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
tests/test_omdao_OC3spar.py Adds empty rigid body configuration structure for test compatibility
tests/test_data/weis_options.yaml Extensive updates to modeling options including rigid body structure and reduced test cases
tests/test_data/weis_inputs.yaml Updates to turbine parameters, platform configuration, and mooring properties
raft/omdao_raft.py Core implementation of rigid body support in OpenMDAO interface
.github/workflows/CI_RAFT.yml Removes conditional logic for MoorPy development branch installation

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@dzalkind dzalkind changed the base branch from struct_dev to dev September 9, 2025 21:40
@lucas-carmo
Copy link
Contributor

Thanks, Dan!

@lucas-carmo lucas-carmo merged commit c73203a into NLRWindSystems:dev Sep 10, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants