Skip to content
This repository was archived by the owner on Aug 12, 2020. It is now read-only.

The travis build script fails #45

Closed
sverhoeven opened this issue Nov 17, 2016 · 6 comments
Closed

The travis build script fails #45

sverhoeven opened this issue Nov 17, 2016 · 6 comments

Comments

@sverhoeven
Copy link
Member

It runs tasks/e2e.sh script which when run locally fails.

@sverhoeven
Copy link
Member Author

Tried to fix tasks/e2e.sh script in `travis-e2e` branch.

Fails with:
```
> node packages/react-scripts/scripts/build.js

Creating an optimized production build...
Error in bail mode: [default] /tmp/gg/packages/react-scripts/node_modules/@nlesc/tslint-config-react-app/node_modules/tslint/custom-typings/resolve.d.ts:28:2
Duplicate identifier 'export='.
```

@sverhoeven
Copy link
Member Author

Disabled Travis-CI build for now, will enable when this issue is fixed.

@bryantee
Copy link

bryantee commented Jan 7, 2017

Is this a bug? My builds were passing on Travis up until a certain commit. Now getting very generic error when building on Travis. Build goes fine locally.

Creating an optimized production build...
Failed to compile.

@sverhoeven
Copy link
Member Author

For PR #47 I enabled Travis-CI again.

Looking at https://travis-ci.org/NLeSC/create-react-app/builds/191663062

  • The Node v6 builds have problems with a tslint rule, this could be corrected by Upgrade tslint to v4 #48.
  • The Node v4 builds are missing Babel somehow

The method used at https://github.com/NLeSC/create-react-app/blob/master/tasks/e2e.sh#L138 to use the react-scripts package seems to have problems with the scoped package name (@nlesc/...). Switching to the method described at https://github.com/NLeSC/create-react-app/blob/master/development-setup.md to install the @nlesc/react-scripts package could be a work around.

@sverhoeven
Copy link
Member Author

@bryantee what is the nodejs version you are using locally?

@bryantee
Copy link

@sverhoeven v6.9.2

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants