This repository was archived by the owner on Aug 12, 2020. It is now read-only.
Merge facebook v0.8.5 #47
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…1051) * Update babel-preset-env to 0.0.8 Changes between 0.0.6 and 0.0.8 should be backwards compatible: https://github.com/babel/babel-preset-env/blob/master/CHANGELOG.md * Use `node: 'current'` as target for babel-preset-env This replaces the hand-rolled node version setup with a new feature that was introduced in babel-preset-env@v0.0.7 https://github.com/babel/babel-preset-env/blob/v0.0.7/CHANGELOG.md
Explain the usage of react-jsx-source & react-jsx-self
…ook#1052) * Update `babel-plugin-transform-object-rest-spread` to v6.19.0 The `babel-plugin-transform-object-rest-spread` v6.19.0 update will allow us to remove the `babel-plugin-transform-es2015-destructuring` and `babel-plugin-transform-es2015-parameters` as the object rest spread transform will now work standalone and not require additional tranforms * Remove unnecessary babel transform plugins from babel-preset-react-app The `babel-plugin-transform-object-rest-spread` v6.19.0 update makes these plugins unnecessary, as v6.19.0 can be used stand-alone
* Correctly checks site url to tab url in reuse check * Bring chrome to foreground focused after tab reuse
In the `create-react-app` command, try to install packages using Yarn. If Yarn is not installed, use npm instead. In `react-scripts`, detect if the project is using Yarn by checking if a `yarn.lock` file exists. If the project is using Yarn, display all the instructions with Yarn commands and use Yarn to install packages in `init` and `eject` scripts.
* Update css-loader to 0.26.0 * Update the production webpack config
…ebook#924) Enable sourcemaps in development
* Add Storybook to the user guide * Add the missing "Snapshot Testing" link. * Change the title to something nicer Old title was looks like a marketing pitch. Change it to something looks great. The new one is: Developing UI Components with React Storybook. * Mention React Storybook as a third party tool. * Nits * Minor changes
* Added info on using global variables. See issue facebook#972. * Fixed typo. * Moved new section. * Small tweaks * Syntax highlighting
Loads all files not already handled by other loaders. Also, switch image loading from file loader to url-loader.
* Adds to docs - deployment with S3/CloudFront * Tweaks
* Remove bundledDependencies * Change the e2e scripts to use local file dependencies instead of bundledDependencies to test the packages
* Replace `scriptPreprocessor` config with `transform`. * Also remove `moduleFileExtensions` which has been redundant since 16.0 (`['js', 'json', 'jsx', 'node’]` is the default)
Revert webpack prod config comments to not refer to dev server.
* Enable useBuiltIns option on object-rest-spread * note polyfill requirement * Enable useBuiltIns with transform-react-jsx * Add direct ref to transform-react-jsx
* add logging of existing port process on start * Move port process wording in start command on to next line * Color the named processes as cyan in terminal output * Add handling for multiple processes on a part - With the currently process filtering, if multiple processes are returned as running on port 3000, this command would fail. This splits apart the process IDing and the process naming, to support multiple processes. - One curious thing about the bash command to get processes, is that it'll include browsers with a window open on localhost:3000. May want to reconsider that. * Add process directory to existing port warning - also moved terminal coloring up, when getting the process, to be able to distinguish the process command from the directory * Change output color to all cyan, except "in" * Rename getProcessNameOnPort -> getProcessForPort - better reflects its broadened scope (both command and directory) * Add checking if process is a CRA instance, to customize port running message - moved from using package.json to a regex, for reliability * Move getProcessForPort to react-dev-utils - also allowed for breakdown of commands into helper methods * Add documentation for getProcessForPort * Add getProcessForPort to list of dev-scripts files * Use app's package name when CRA app is running on another port * Filter port process by those listening - Removed the handling of multiple process IDs since you can filtering by listening process (and not have the browser in the list of processes) - Trimmed the terminal outputs for better matching (process id) and better terminal output (directory of process) * Update README on port helpers, to specify only one port returned * Add ignore of stderr when executing process commands - Make sure any potential errors don't leak to the user
* Add a note for OSX users about watchman and jest Minor additional information on how to solve watchman problems reported in facebook#713 and facebook#1767 * Introduced new Troubleshooting section Add better explanation how to solve facebook#713 and linked related Issues. * Tweak wording and add it to TOC
…1215) - Use “Chrome” instead of "Google Chrome", It will try to use current active browser. otherwise, use default. - If “Chrome”s aren’t running, will fallback to opn(url)
* Remove the “‘yarn’ is not recognized as an internal or external command, ...” message on Windows * Simplify the detection code: just run `yarn --version` – if it succeeds use `yarn`, if it fails use `npm`.
Previously create-react-app exited with 0 after an installation error.
* Update CONTRIBUTING.md * Add more detailed change log instructions
…#1212) * Proxy rewrites Origin header to match the target server URL * Added comments on rewriting Origin header by the proxy middleware
* Use "commander" for cli argv handling * Handle different scripts version forms and exits without a name given * Revert comment about min supported node version * Check sooner for the minimal node version * Add travis test for node <4 * Parse stderr in node versions <4
* Tweak minimal Node error message * Tweak console messages * It doesn't need to be from npm * Try to fix e2e test
There’s a common tool included in Hadoop that also has a `yarn` command, which created issues for users who had Hadoop installed: * facebook#1257 * facebook#1363 Yarn also installs the command under `yarnpkg` alias (added in yarnpkg/yarn@cefa9a3) so we can use `yarnpkg` instead of `yarn` to make it more reliable. This has no effect on users who don't have Hadoop installed, but those who have won't see errors from falsely detecting Hadoop Yarn as Yarn the package manager, and they can now also install Yarn to make use of our Yarn support without the Hadoop Yarn interfering.
|
For me the following commands work correctly: Added code in 100% covered file, which cause coverage to drop. Also tested with yarn by installing it with |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our master branch was forked from facebookincubator/create-react-app on 1 Nov 2016.
In this branch the changes of the facebookincubator/create-react-app v0.8.5 tag have been merged.
This branch should be tested by generating apps with npm and yarn and at least test all the npm commands and verify the test coverage still works.