-
-
Notifications
You must be signed in to change notification settings - Fork 26.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unnecessary transform plugins for object spread to work #1052
Remove unnecessary transform plugins for object spread to work #1052
Conversation
What does the failure look like? |
cc @hzoo |
The error I get on node v6.7.0 is visible in this gist: https://gist.github.com/valscion/25989e714380f2eabe52d170d6ca6f41
It looks like this:
I'm not sure whether I have everything set up properly, but I've cleaned my I added a commit valscion@9efbc7c that contains patch that should be legit, but crashes. This gist contains both the patch and the stacktrace: https://gist.github.com/valscion/25989e714380f2eabe52d170d6ca6f41 |
You should be updating object-rest-spread to v6.19.0 😄 that's all - it's currently |
D'oh! |
The `babel-plugin-transform-object-rest-spread` v6.19.0 update will allow us to remove the `babel-plugin-transform-es2015-destructuring` and `babel-plugin-transform-es2015-parameters` as the object rest spread transform will now work standalone and not require additional tranforms
The `babel-plugin-transform-object-rest-spread` v6.19.0 update makes these plugins unnecessary, as v6.19.0 can be used stand-alone
5cd0933
to
7554d30
Compare
Ok, that should fix it, and now I don't get any errors anymore 😅 😅 😅 😅 Thanks @hzoo for pointing out my silly mistake! Funny how some things slip your eye so easily 😂 |
I would add the 2 tests back as well
|
They haven't been there ever, I just used them to test the local changes. I think it's out of scope of this PR? |
LGTM |
* pull2: Support Yarn (facebook#898) Fix chrome tab reuse (facebook#1035) Remove unnecessary transform plugins for object spread to work (facebook#1052) Clears the usage of react-jsx-source & react-jsx-self (facebook#992) Update babel-present-env and use node: 'current' as target (facebook#1051) Remove redundant `function` from export statement (facebook#996) Add Gatsby to alternatives (facebook#995) Allow webpack 2 as peerDependency in react-dev-utils (facebook#963) Remove custom babel-loader cache dir config (facebook#983) Check for presence of folders before continuing eject. Closes facebook#939. (facebook#951) Fixes facebook#952 (facebook#953) Always build before deploying to gh-pages (facebook#959) Add collectCoverageFrom option to collect coverage on files without any tests. (facebook#961) Catch and noop call to open web browser. (facebook#964) Gently nudge users towards https by default (facebook#974) Enable compression on webpack-dev-server (facebook#966) (facebook#968) Add next.js to Alternatives Point people to npm Windows instructions Encourage people to try recent npm # Conflicts: # packages/react-scripts/config/webpack.config.dev.js # packages/react-scripts/package.json # packages/react-scripts/utils/createJestConfig.js
…ook#1052) * Update `babel-plugin-transform-object-rest-spread` to v6.19.0 The `babel-plugin-transform-object-rest-spread` v6.19.0 update will allow us to remove the `babel-plugin-transform-es2015-destructuring` and `babel-plugin-transform-es2015-parameters` as the object rest spread transform will now work standalone and not require additional tranforms * Remove unnecessary babel transform plugins from babel-preset-react-app The `babel-plugin-transform-object-rest-spread` v6.19.0 update makes these plugins unnecessary, as v6.19.0 can be used stand-alone
…ook#1052) * Update `babel-plugin-transform-object-rest-spread` to v6.19.0 The `babel-plugin-transform-object-rest-spread` v6.19.0 update will allow us to remove the `babel-plugin-transform-es2015-destructuring` and `babel-plugin-transform-es2015-parameters` as the object rest spread transform will now work standalone and not require additional tranforms * Remove unnecessary babel transform plugins from babel-preset-react-app The `babel-plugin-transform-object-rest-spread` v6.19.0 update makes these plugins unnecessary, as v6.19.0 can be used stand-alone
…ook#1052) * Update `babel-plugin-transform-object-rest-spread` to v6.19.0 The `babel-plugin-transform-object-rest-spread` v6.19.0 update will allow us to remove the `babel-plugin-transform-es2015-destructuring` and `babel-plugin-transform-es2015-parameters` as the object rest spread transform will now work standalone and not require additional tranforms * Remove unnecessary babel transform plugins from babel-preset-react-app The `babel-plugin-transform-object-rest-spread` v6.19.0 update makes these plugins unnecessary, as v6.19.0 can be used stand-alone
The
babel-plugin-transform-object-rest-spread
v6.19.0 update made the other two plugins unnecessary as it contains the fixes done in babel/babel#4755https://github.com/babel/babel/blob/v6.19.0/CHANGELOG.md
Ref #904 (comment) and #927
Test plan
1. Use
node
v6.7.0If you use
nvm
, this is how:2. (Optional, I think) Use npm v2
3. Modify
App.test.js
Modify
packages/react-scripts/template/src/App.test.js
to look like this:4. Install all the packages and run the test script