-
-
Notifications
You must be signed in to change notification settings - Fork 26.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a note for OSX users about watchman and jest #1080
Conversation
Minor additional information on how to solve watchman problems reported in facebook#713 and facebook#1767
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks! If you are contributing on behalf of someone else (eg your employer): the individual CLA is not sufficient - use https://developers.facebook.com/opensource/cla?type=company instead. Contact cla@fb.com if you have any questions. |
Can you create a new top-level Troubleshooting section at the very end and put it there? We'll have a few more troubleshooting recipes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please move to a separate section and fix nits
@@ -675,6 +675,14 @@ The watcher includes an interactive command-line interface with the ability to r | |||
|
|||
![Jest watch mode](http://facebook.github.io/jest/img/blog/15-watch.gif) | |||
|
|||
>**A note for Mac OSX users** | |||
|
|||
>If you start `npm test` and the execution hangs there might be a problem with your watchman installation as discovered in #713 and #1767. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make watchman and issues links.
|
||
>If you start `npm test` and the execution hangs there might be a problem with your watchman installation as discovered in #713 and #1767. | ||
|
||
> To solve the issues first make sure you run the latest verision: `brew install watchman` (4.7.0). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo, should be "version".
Let's not hardcode specific version but say "make sure you run at least watchman 4.7.0 or newer".
Add better explanation how to solve facebook#713 and linked related Issues.
Thank you for your feedback, I added the new section as you requested and linked the articles |
Thanks! I tweaked the wording a little. Really appreciate it! |
* Add a note for OSX users about watchman and jest Minor additional information on how to solve watchman problems reported in facebook#713 and facebook#1767 * Introduced new Troubleshooting section Add better explanation how to solve facebook#713 and linked related Issues. * Tweak wording and add it to TOC
* Add a note for OSX users about watchman and jest Minor additional information on how to solve watchman problems reported in facebook#713 and facebook#1767 * Introduced new Troubleshooting section Add better explanation how to solve facebook#713 and linked related Issues. * Tweak wording and add it to TOC
* Add a note for OSX users about watchman and jest Minor additional information on how to solve watchman problems reported in facebook#713 and facebook#1767 * Introduced new Troubleshooting section Add better explanation how to solve facebook#713 and linked related Issues. * Tweak wording and add it to TOC
Minor additional information on how to solve watchman problems reported in #713 and #1767