Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move generated package to src/ layout #374

Merged
merged 2 commits into from
May 15, 2024
Merged

Move generated package to src/ layout #374

merged 2 commits into from
May 15, 2024

Conversation

sjvrijn
Copy link
Contributor

@sjvrijn sjvrijn commented Feb 19, 2024

Description

This PR moves the generated package to the src/ based layout.
I think I've propagated this change everywhere necessary, and all tests currently pass.

Related issues:

@Cmurilochem
Copy link

Hi @sjvrijn and @egpbos . I could take care of this one and provide a review as soon as I get some time (probably next week or so). Please, could you add me as a reviewer ? Thanks!

@egpbos
Copy link
Member

egpbos commented Apr 23, 2024

@Cmurilochem I was puzzled why you didn't have access, but for some reason you weren't part of the NLeSC/employees group (which has access to the repo). Now you are and you can do reviews (and everything else) :)

@egpbos egpbos requested a review from Cmurilochem April 23, 2024 15:58
Copy link

@Cmurilochem Cmurilochem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thanks for the clarification. Great job!

@sjvrijn sjvrijn mentioned this pull request May 3, 2024
2 tasks
@egpbos egpbos merged commit fc8f91b into main May 15, 2024
16 checks passed
@sjvrijn sjvrijn deleted the src-layout branch July 29, 2024 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move package to src/package
3 participants