Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build.yml workflow #647

Merged
merged 2 commits into from
Aug 30, 2024
Merged

Fix build.yml workflow #647

merged 2 commits into from
Aug 30, 2024

Conversation

abelsiqueira
Copy link
Member

@abelsiqueira abelsiqueira commented Aug 29, 2024

Checklist before requesting a review

  • I have read the contribution guidelines
  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • All user facing changes have been added to CHANGELOG.md

Type of change

  • Bug fix (non-breaking change which fixes an issue)

List of related issues or pull requests**

Refs:

Describe the changes made in this pull request

The build.yml was broken because it was not being processed by Jinja. Adding the .jinja extension fixed that.
Then it was broken because whitespace stripping was concatenating the lint from AddLinting.

Instructions to review the pull request

Suggestions for review:

Install the requirements

cd $(mktemp -d --tmpdir py-tmpl-XXXXXX)
pip install pipx
pipx install copier

Create a new package using the template

copier copy --vcs-ref <YOUR_BRANCH> https://github.com/nlesc/python-template test_package

Create a local git repo to push to GitHub to trigger CI actions

git init
git add --all
git commit -m "First commit"
git remote add origin git@github.com:<YOU>/python-template-test.git
git push -u origin main -f

@abelsiqueira abelsiqueira changed the title Fix missing .jinja in build.yml workflow Fix build.yml workflow Aug 29, 2024
@abelsiqueira abelsiqueira marked this pull request as ready for review August 29, 2024 19:53
Copy link
Member

@fdiblen fdiblen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected. Thank you, @abelsiqueira

@fdiblen fdiblen merged commit 92994b5 into main Aug 30, 2024
18 checks passed
@fdiblen fdiblen deleted the 636-bug-invalid-workflow-file branch August 30, 2024 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants