Allow suppression of pidfiles. #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When unbound is maintained by a system manager that can actually keep track of what daemons are running correctly, a pidfile is an opportunity for extra failures, rather than a way to avoid failures. In particular, if unbound terminates roughly, it might leave the pidfile lying around. Then a subsequent unbound instance will think that another unbound process is running when it isn't (particularly if some other stable process happens to have landed on the same process ID). So for a system manager that is already capable of keeping track of whether the daemon is running or not, it would be nice to have the ability to avoid these extra failure modes by just ignoring pidfiles entirely. Since the same unbound config file might need to be used on a distribution that might use different system managers, being able to control the use of a pidfile by a command-line argument is probably the cleanest way to go (see https://bugs.debian.org/867192).
|
Closing this PR, was also submitted as patch to our bugzilla (https://www.nlnetlabs.nl/bugs-script/show_bug.cgi?id=1349) and is applied. |
gthess
referenced
this pull request
in gthess/unbound
Apr 22, 2020
Updated documentation to include pyunbound and patch for DS algorithms and added example zonefiles
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When unbound is maintained by a system manager that can actually keep
track of what daemons are running correctly, a pidfile is an
opportunity for extra failures, rather than a way to avoid failures.
In particular, if unbound terminates roughly, it might leave the
pidfile lying around. Then a subsequent unbound instance will think
that another unbound process is running when it isn't (particularly if
some other stable process happens to have landed on the same process
ID).
So for a system manager that is already capable of keeping track of
whether the daemon is running or not, it would be nice to have the
ability to avoid these extra failure modes by just ignoring pidfiles
entirely.
Since the same unbound config file might need to be used on a
distribution that might use different system managers, being able to
control the use of a pidfile by a command-line argument is probably
the cleanest way to go (see https://bugs.debian.org/867192).