Support OpenSSLs that lack SSL_get0_alpn_selected. #466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atoomic
reviewed
Apr 19, 2021
| @@ -1314,6 +1314,7 @@ ssl_handshake(struct comm_point* c) | |||
| c->repinfo.addrlen); | |||
| } | |||
|
|
|||
| #ifdef HAVE_SSL_GET0_ALPN_SELECTED | |||
wcawijngaards
added a commit
that referenced
this pull request
Apr 22, 2021
- Merge #466 from FGasper: Support OpenSSLs that lack SSL_get0_alpn_selected.
|
Thank you for the patch. Added autoconf and test to make dohclient compile, to make 'make test' succeed. That makes it compile. If you try to use http2 unbound fails with an error that ALPN is necessary to use http2 functionality. |
jedisct1
added a commit
to jedisct1/unbound
that referenced
this pull request
Apr 22, 2021
* nlnet/master: (61 commits) - Fix that testcode dohclient has OpenSSL initialisation calls. - Further fix for NLnetLabs#468: detect SSL_CTX_set_alpn_protos for build with OpenSSL 1.0.1. - Fix NLnetLabs#468: OpenSSL 1.0.1 can no longer build Unbound. Changelog note for NLnetLabs#466 - Merge NLnetLabs#466 from FGasper: Support OpenSSLs that lack SSL_get0_alpn_selected. Support OpenSSLs that lack SSL_get0_alpn_selected. - Remove unused functions worker_handle_reply and libworker_handle_reply. - Fix documentation comment for files previously residing in checkconf/. - Fix that nxdomain synthesis does not happen above the stub or forward definition. - Fix (increase) verbosity level for iterator error log in processQueryTargets(). - Fix permission denied sendto log, squelch the log messages unless high verbosity is set. - rebuild configure to set EXTRALINK to libunbound.la for NLnetLabs#460. - Fix for NLnetLabs#411: Depth protect for crash on deleted element timeout. - Fix to stop IPv6 PMTU discovery. Changelog note for NLnetLabs#460. - Merge NLnetLabs#460 from orbea: build: Link with the libtool archive. build: Link with the libtool archive. - Clean makedist.sh. - Fix stack-protector change to not override other CFLAGS options. - Disable the use of stack-protector for cross compiled 32-bit windows builds; relates to NLnetLabs#444. - Fix NLnetLabs#429: Also fix end of transfer for http download of auth zones. - Fix that cachedb does not produce empty object files when disabled. ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unbound currently doesn’t build on CloudLinux 6. This patch seems to fix the issue, though I’m still confirming.