Support TargetDefaultWrapper and TargetDefaultParameters (code review)

NLog · Apr 28, 2021 · dd29028 · dd29028
1 parent 6ff3e6c
commit dd29028
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/src/NLog.Extensions.Logging/Config/NLogLoggingConfiguration.cs b/src/NLog.Extensions.Logging/Config/NLogLoggingConfiguration.cs
@@ -316,13 +316,13 @@ private IConfigurationSection GetTargetDefaultParametersSection()
                 if (_topElement)
                 {
                     var targetDefaultParameters = _configurationSection.GetSection(TargetDefaultParameters);
-                    if (targetDefaultParameters != null && targetDefaultParameters.GetChildren().Any())
+                    if (targetDefaultParameters?.GetChildren().Any() == true)
                     {
                         return targetDefaultParameters;
                     }
 
                     targetDefaultParameters = _configurationSection.GetSection(DefaultTargetParameters);
-                    if (targetDefaultParameters != null && targetDefaultParameters.GetChildren().Any())
+                    if (targetDefaultParameters?.GetChildren().Any() == true)
                     {
                         return targetDefaultParameters;
                     }
@@ -336,13 +336,13 @@ private IConfigurationSection GetTargetDefaultWrapperSection()
                 if (_topElement)
                 {
                     var targetDefaultWrapper = _configurationSection.GetSection(TargetDefaultWrapper);
-                    if (targetDefaultWrapper != null && targetDefaultWrapper.GetChildren().Any())
+                    if (targetDefaultWrapper?.GetChildren().Any() == true)
                     {
                         return targetDefaultWrapper;
                     }
 
                     targetDefaultWrapper = _configurationSection.GetSection(DefaultWrapper);
-                    if (targetDefaultWrapper != null && targetDefaultWrapper.GetChildren().Any())
+                    if (targetDefaultWrapper?.GetChildren().Any() == true)
                     {
                         return targetDefaultWrapper;
                     }

diff --git a/src/NLog.Extensions.Logging/Config/SetupBuilderExtensions.cs b/src/NLog.Extensions.Logging/Config/SetupBuilderExtensions.cs
@@ -17,7 +17,7 @@ public static ISetupBuilder LoadConfigurationFromSection(this ISetupBuilder setu
             if (!string.IsNullOrEmpty(configSection))
             {
                 var nlogConfig = configuration.GetSection(configSection);
-                if (nlogConfig != null && nlogConfig.GetChildren().Any())
+                if (nlogConfig?.GetChildren().Any() == true)
                 {
                     setupBuilder.LogFactory.Configuration = new NLogLoggingConfiguration(nlogConfig, setupBuilder.LogFactory);
                 }