Skip to content

Commit

Permalink
Merge pull request #152 from snakefoot/master
Browse files Browse the repository at this point in the history
Introduced NetStandard1.5 by updating to NLog 4.5-beta07
  • Loading branch information
304NotModified authored Oct 16, 2017
2 parents 3306262 + 53fa92d commit f41a0ae
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 7 deletions.
11 changes: 8 additions & 3 deletions src/NLog.Extensions.Logging/NLog.Extensions.Logging.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
For ASP.NET Core, use NLog.Web.AspNetCore: https://www.nuget.org/packages/NLog.Web.AspNetCore</Description>

<Authors>Microsoft;Julian Verdurmen</Authors>
<TargetFrameworks>net451;net461;netstandard1.3;netstandard2.0</TargetFrameworks>
<TargetFrameworks>net451;net461;netstandard1.3;netstandard1.5;netstandard2.0</TargetFrameworks>
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
<AssemblyName>NLog.Extensions.Logging</AssemblyName>
<AssemblyOriginatorKeyFile>NLog.snk</AssemblyOriginatorKeyFile>
Expand Down Expand Up @@ -43,7 +43,7 @@ For ASP.NET Core, use NLog.Web.AspNetCore: https://www.nuget.org/packages/NLog.W
<Reference Include="System" />
<Reference Include="Microsoft.CSharp" />
</ItemGroup>
<PropertyGroup Condition=" '$(TargetFramework)' == 'netstandard1.3' Or '$(TargetFramework)' == 'netstandard2.0'">
<PropertyGroup Condition=" '$(TargetFramework)' == 'netstandard1.3' Or '$(TargetFramework)' == 'netstandard1.5' Or '$(TargetFramework)' == 'netstandard2.0'">
<DefineConstants>$(DefineConstants);NETCORE</DefineConstants>
</PropertyGroup>
<PropertyGroup>
Expand All @@ -54,9 +54,14 @@ For ASP.NET Core, use NLog.Web.AspNetCore: https://www.nuget.org/packages/NLog.W
<PackageReference Include="NLog" Version="5.0.0-beta11" />
<PackageReference Include="System.AppContext" Version="4.3.0" />
</ItemGroup>
<ItemGroup Condition=" '$(TargetFramework)' == 'netstandard1.5' ">
<PackageReference Include="Microsoft.Extensions.Logging.Abstractions" Version="1.1.2" />
<PackageReference Include="NLog" Version="4.5.0-beta07" />
<PackageReference Include="System.AppContext" Version="4.3.0" />
</ItemGroup>
<ItemGroup Condition=" '$(TargetFramework)' == 'netstandard2.0' ">
<PackageReference Include="Microsoft.Extensions.Logging" Version="2.0.0" />
<PackageReference Include="NLog" Version="4.5.0-beta06" />
<PackageReference Include="NLog" Version="4.5.0-beta07" />
<PackageReference Include="System.AppContext" Version="4.3.0" />
</ItemGroup>
</Project>
4 changes: 2 additions & 2 deletions test/LoggerTests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ public void TestMessageProperties()
GetRunner().LogDebugWithMessageProperties();

var target = GetTarget();
Assert.Equal("NLog.Extensions.Logging.Tests.LoggerTests.Runner|DEBUG|message with id and 1 property |01", target.Logs.FirstOrDefault());
Assert.Equal("NLog.Extensions.Logging.Tests.LoggerTests.Runner|DEBUG|message with id and 1 property |1", target.Logs.FirstOrDefault());
}

[Fact]
Expand All @@ -69,7 +69,7 @@ public void TestScopeProperties()
GetRunner().LogWithScopeParameters();

var target = GetTarget();
Assert.Equal("NLog.Extensions.Logging.Tests.LoggerTests.Runner|DEBUG|message with id and 1 parameters |0Hello", target.Logs.FirstOrDefault());
Assert.Equal("NLog.Extensions.Logging.Tests.LoggerTests.Runner|DEBUG|message with id and 1 parameters |Hello", target.Logs.FirstOrDefault());
}

[Theory]
Expand Down
4 changes: 2 additions & 2 deletions test/NLog.Extensions.Logging.Tests.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -16,13 +16,13 @@
<ItemGroup Condition=" '$(TargetFramework)' == 'netcoreapp1.1' ">
<PackageReference Include="Microsoft.Extensions.DependencyInjection" Version="1.1.1" />
<PackageReference Include="Microsoft.Extensions.Logging" Version="1.1.2" />
<PackageReference Include="NLog" Version="5.0.0-beta11" />
<PackageReference Include="NLog" Version="4.5.0-beta07" />
<PackageReference Include="System.AppContext" Version="4.3.0" />
</ItemGroup>
<ItemGroup Condition=" '$(TargetFramework)' == 'netcoreapp2.0' ">
<PackageReference Include="Microsoft.Extensions.DependencyInjection" Version="2.0.0" />
<PackageReference Include="Microsoft.Extensions.Logging" Version="2.0.0" />
<PackageReference Include="NLog" Version="4.5.0-beta06" />
<PackageReference Include="NLog" Version="4.5.0-beta07" />
<PackageReference Include="System.AppContext" Version="4.3.0" />
</ItemGroup>

Expand Down

0 comments on commit f41a0ae

Please sign in to comment.