Difference in dependency behavior for variables in appsettings.json vs NLog.config #736
Labels
Comments
|
Yes was also surprised that keys was sorted automatically when I did the initial implementation of loading NLog configuration from Since variables has the ability to reference other variables, then I guess one could make some funky logic that tries to produce custom sorting order when recognizing references. But the funky logic should be local in this repository. Pull requests are wellcome. |
|
Created #737 to improve the user-experience, when config-variables depends on other variables. |
|
NLog.Extensions.Logging v5.3.9 has been released, that should improve the user-experience when referencing configuration-variables. |
|
Awesome! Thanks kindly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Type: Bug(?)
NLog version: 5.2.8
NLog.Extensions.Logging version: 5.3.8
NLog.Web.AspNetCore version: N/A
Platform: .NET Standard 2.0, .NET Framework 4.8, .NET 8
Current NLog config
Converting from XML:
Found while converting to
{ "NLog": { "variables": { "logDir": "C:\\Logs", "archiveDir": "${logDir}\\Archive", "appName": "${hosted-app-name}${when:when='${hosted-app-name}' == '':inner=${replace:searchFor=.vshost:replaceWith=:regex=false:inner=${processname}}}", "appDomainId": "${appdomain:format={0\\}}", "logName": "${when:when='${appDomainId}' != '1':inner=${appdomain:format={0\\}-{1\\}_}}${appName}", "MicrosoftLevel": "${level:lowercase=true:truncate=4:when=level==LogLevel.Info or level==LogLevel.Warn}${when:when=level==LogLevel.Error:inner=fail}${when:when=level==LogLevel.Fatal:inner=crit}${when:when=level==LogLevel.Debug:inner=dbug}", "MicrosoftLayout": "${MicrosoftLevel}: ${logger}[${event-properties:EventId_Id:whenEmpty=0}]${newline} ${message}${onexception:inner=${newline}${exception:format=tostring}}" } } }Expected Result:
Variables can reference each other
Actual Result:
While writing this up, with some tinkering I was able to identify what I think is the cause of the issue and, in understanding that, I'm not certain if it will be considered a bug or a feature request or maybe just some additional documentation if it's decided that a fix is more work than its worth.
It appears that the main difference here is that NLog.config processes variables in the order they are defined, whereas the appsettings variety seems like it may be processing them in alphabetical order (probably a result of the underlying implementation details of the IConfiguration system). After fixing
logDirby renaming it toz-logDir,MicrosoftLayoutthrew the same exception due to it referencingMicrosoftLevel(these names come straight from the documentation here).Ideally it would be nice if the variables could still reference each other without needing to consider alphabetical ordering of their names, whether it did some sort of dependency sorting internally while parsing, or if there was a way to help it identify them with some additional json properties or some such.
Workaround:
{ "NLog": { "variables": { "logDir": "C:\\Logs", "z-archiveDir": "${logDir}\\Archive", "appName": "${hosted-app-name}${when:when='${hosted-app-name}' == '':inner=${replace:searchFor=.vshost:replaceWith=:regex=false:inner=${processname}}}", "appDomainId": "${appdomain:format={0\\}}", "logName": "${when:when='${appDomainId}' != '1':inner=${appdomain:format={0\\}-{1\\}_}}${appName}", "MicrosoftLevel": "${level:lowercase=true:truncate=4:when=level==LogLevel.Info or level==LogLevel.Warn}${when:when=level==LogLevel.Error:inner=fail}${when:when=level==LogLevel.Fatal:inner=crit}${when:when=level==LogLevel.Debug:inner=dbug}", "z-MicrosoftLayout": "${MicrosoftLevel}: ${logger}[${event-properties:EventId_Id:whenEmpty=0}]${newline} ${message}${onexception:inner=${newline}${exception:format=tostring}}" } } }The text was updated successfully, but these errors were encountered: