Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto ordering of variables-section when dependent variables #737

Merged
merged 1 commit into from
Apr 21, 2024

Conversation

snakefoot
Copy link
Contributor

@snakefoot snakefoot commented Apr 21, 2024

Trying to resolve #736

This is not a perfect safety-net, but will catch the most obvious cases, when using references to other variables. To improve the user-experience when the automatic ordering interferes unexpectedly.

It will fallback to the original order when unable to unravel the correct ordering.

@codecov-commenter
Copy link

codecov-commenter commented Apr 21, 2024

Codecov Report

Attention: Patch coverage is 71.42857% with 16 lines in your changes are missing coverage. Please review.

Project coverage is 80.83%. Comparing base (b77d209) to head (e300f3b).
Report is 1 commits behind head on master.

Files Patch % Lines
...ensions.Logging/Config/NLogLoggingConfiguration.cs 71.42% 9 Missing and 7 partials ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #737      +/-   ##
==========================================
- Coverage   81.18%   80.83%   -0.35%     
==========================================
  Files          19       19              
  Lines        1743     1790      +47     
  Branches      311      319       +8     
==========================================
+ Hits         1415     1447      +32     
- Misses        188      197       +9     
- Partials      140      146       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@snakefoot snakefoot force-pushed the auto-sort-variables branch from 312c4cc to a583e5b Compare April 21, 2024 17:44
@snakefoot snakefoot force-pushed the auto-sort-variables branch from a583e5b to e300f3b Compare April 21, 2024 17:47
@snakefoot snakefoot closed this Apr 21, 2024
@snakefoot snakefoot reopened this Apr 21, 2024
@snakefoot snakefoot merged commit 3f70293 into NLog:master Apr 21, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Difference in dependency behavior for variables in appsettings.json vs NLog.config
2 participants