-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Console Example #143
Conversation
|
||
services.AddTransient<Runner>(); | ||
// services.AddSingleton<ILoggerFactory, NLogLoggerFactory>(); | ||
services.AddSingleton<ILoggerFactory, LoggerFactory>(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@snakefoot any idea why the structured logging won't work if I use
services.AddSingleton<ILoggerFactory, NLogLoggerFactory>();
instead of
services.AddSingleton<ILoggerFactory, LoggerFactory>();
(also in unit tests)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't know much of about this, so no
6011a49
to
aedbc18
Compare
aedbc18
to
ca4e059
Compare
@304NotModified Think this code-example needs some minor modifications: Csproj-project needs the following package references:
Program.cs needs configuration of ILoggingBuilder:
|
Are those references needed? ILoggingBuilder config looks good! |
Well you have the package-references listed on the wiki-page, just missing from this example project (not sure why, since it cannot compile and run without these references): The bonus reference "Microsoft.Extensions.Logging.Filter" seems to be needed for calling |
I do not have any reference to "Microsoft.Extensions.Logging.Filter" and I can call |
fixes #131