Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement .NET standard 2 features for .NET 4.6.1 + update dependencies #172

Closed
wants to merge 1 commit into from
Closed

Implement .NET standard 2 features for .NET 4.6.1 + update dependencies #172

wants to merge 1 commit into from

Conversation

304NotModified
Copy link
Member

@304NotModified 304NotModified commented Nov 30, 2017 •
edited
Loading

supersedes #171

.NET 4.5 is still NLog 4.4.x+

@304NotModified 304NotModified added this to the 1.0.0-rtm-rc3 milestone Nov 30, 2017
@304NotModified 304NotModified force-pushed the net461-like-netstandard2 branch from c5ebf88 to e59ef47 Compare November 30, 2017 21:24
@304NotModified 304NotModified mentioned this pull request Nov 30, 2017
Merged
@304NotModified 304NotModified force-pushed the net461-like-netstandard2 branch from e59ef47 to ae27090 Compare November 30, 2017 21:33
@snakefoot
Copy link
Contributor

snakefoot commented Nov 30, 2017 •
edited
Loading

Same as #171 ? (Just without enforcing NLog 4.5 for net451, and missing MessageTemplates for NetStandard1.5 + net451)

@304NotModified
Copy link
Member Author

yes, when I checked the PR, it looks almost the same :P -- oops

@304NotModified 304NotModified force-pushed the net461-like-netstandard2 branch from ae27090 to 6e26710 Compare November 30, 2017 21:58
@snakefoot
Copy link
Contributor

Would be nice if these two released together:

  • NLog 4.5 RTM
  • NLog.Extensions.Logging ver. 1.0 RTM (NLog 4.5 as minimum version)

Don't know the state of NLog.Web.AspNetCore ver. 4.5

@304NotModified
Copy link
Member Author

fixed.

I was a bit confused by the title and description of #171

@304NotModified
Copy link
Member Author

304NotModified commented Nov 30, 2017 •
edited
Loading

Don't know the state of NLog.Web.AspNetCore ver. 4.5

RTM when NLog 4.5 RTM + NLog.Extensions.Logging ver. 1.0 RTM (NLog 4.5 as minimum version).

so also related

@snakefoot
Copy link
Contributor

snakefoot commented Nov 30, 2017 •
edited
Loading

Why is net451 then not using NLog 4.5-rc01 ? Cannot see how this PR supersedes

@304NotModified
Copy link
Member Author

yeah, now also doubting about this. I don't like forcing to a rc, but then we are indeed missing the templated stuff

@snakefoot
Copy link
Contributor

yeah, now also doubting about this. I don't like forcing to a rc, but then we are indeed missing the templated stuff

I'm guessing we are very close to RTM, so the version should match the coming RTM. Atleast if you want to find some bugs.

@304NotModified
Copy link
Member Author

true, thanks

ok will merge #171. an "alternative" way to find out that the best ;)

@304NotModified 304NotModified deleted the net461-like-netstandard2 branch December 5, 2017 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0.0-rtm-rc3
Development

Successfully merging this pull request may close these issues.
2 participants
@304NotModified @snakefoot