BeginScope accepts any type of KeyValuePair and Dictionary

[snakefoot]

Make BeginScope more user-friendly by accepting any type of KeyValuePair.

There is an overhead from lookup in ConcurrentDictionary and boxing, so maybe one should just write to the InternalLogger instead of doing reflection.

[304NotModified]

AFAIK we could use the pattern matching with open generics (c# 7.1 - https://github.com/dotnet/csharplang/blob/master/proposals/csharp-7.1/generics-pattern-match.md).

That would preform better I think

update: not sure if that will work, we need to know T etc I think.

It's a bit pity KeyValuePair isn't implementing a covariant interface

[codecov]

Codecov Report

Merging #223 into master will increase coverage by 0.17%.
The diff coverage is 71.69%.

@@            Coverage Diff             @@
##           master     #223      +/-   ##
==========================================
+ Coverage   72.15%   72.32%   +0.17%     
==========================================
  Files           6        6              
  Lines         316      365      +49     
  Branches       75       89      +14     
==========================================
+ Hits          228      264      +36     
- Misses         59       65       +6     
- Partials       29       36       +7

Impacted Files	Coverage Δ
src/NLog.Extensions.Logging/Logging/NLogLogger.cs	74.31% <71.69%> (-0.84%)	⬇️
...g.Extensions.Logging/Logging/NLogLoggerProvider.cs	94.28% <0%> (+2.85%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d0d78f...b340362. Read the comment docs.

[snakefoot]

That would preform better I think

Changed the logic into using cached expression-trees, then the performance should not be super horrible.

[snakefoot]

@304NotModified Please make one more review, when you get the time. Now one can also inject a single KeyValuePair instead of a whole list.

[304NotModified]

Thanks, I'm on holiday but will try to find some time these days

[304NotModified]

merged! Thanks!