Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added NLogProviderOptions.ShutdownOnDispose #314

Merged
merged 1 commit into from
Jul 12, 2019
Merged

Added NLogProviderOptions.ShutdownOnDispose #314

merged 1 commit into from
Jul 12, 2019

Conversation

304NotModified
Copy link
Member

Fixes #313

@304NotModified 304NotModified added this to the 1.5.2 milestone Jul 12, 2019
@304NotModified 304NotModified requested a review from snakefoot July 12, 2019 20:05
@codecov-io
Copy link

codecov-io commented Jul 12, 2019 •
edited
Loading

Codecov Report

Merging #314 into dev will decrease coverage by 0.24%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #314      +/-   ##
==========================================
- Coverage   81.69%   81.44%   -0.25%     
==========================================
  Files          12       12              
  Lines        1087     1094       +7     
  Branches      190      191       +1     
==========================================
+ Hits          888      891       +3     
- Misses        138      141       +3     
- Partials       61       62       +1
Impacted Files Coverage Δ
....Extensions.Logging/Logging/NLogProviderOptions.cs 100% <100%> (ø) ⬆️
...g.Extensions.Logging/Logging/NLogLoggerProvider.cs 90.14% <42.85%> (-5.25%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7db58f7...e27f255. Read the comment docs.

snakefoot
snakefoot approved these changes Jul 12, 2019
View reviewed changes
Copy link
Contributor

@snakefoot snakefoot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@304NotModified 304NotModified merged commit 7d98a74 into dev Jul 12, 2019
@304NotModified 304NotModified deleted the ShutdownOnDispose branch July 12, 2019 21:13
@snakefoot snakefoot mentioned this pull request Jul 20, 2019
Closed
This was referenced Aug 30, 2019
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snakefoot snakefoot snakefoot approved these changes

Assignees
No one assigned
Labels
feature size/S
Projects
None yet
Milestone
1.5.2
Development

Successfully merging this pull request may close these issues.

Add NLogLoggingConfiguration for shutdown on dispose
3 participants
@304NotModified @codecov-io @snakefoot