-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NLogLogger - Reduce allocation by not boxing EventId when CaptureEntireEventId = false #319
Conversation
Codecov Report
@@ Coverage Diff @@
## master #319 +/- ##
=========================================
+ Coverage 81.82% 81.9% +0.07%
=========================================
Files 12 12
Lines 1150 1166 +16
Branches 195 198 +3
=========================================
+ Hits 941 955 +14
- Misses 140 141 +1
- Partials 69 70 +1
Continue to review full report at Codecov.
|
952ba47
to
e22a191
Compare
this is a behavior change, isn't? |
Yes. Instead of having 3 EventId-properties to store Id + Name, then it now only uses 2. I guess we could wait with this PR until NLog 5.0 has been released, then we can bump this to ver. 2.0 |
Good plan! |
(WIP) for 2.0 release |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Codecov Report
@@ Coverage Diff @@
## master #319 +/- ##
==========================================
- Coverage 82.22% 81.90% -0.32%
==========================================
Files 14 12 -2
Lines 1198 1166 -32
Branches 200 198 -2
==========================================
- Hits 985 955 -30
Misses 141 141
+ Partials 72 70 -2
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #319 +/- ##
==========================================
+ Coverage 81.41% 81.48% +0.06%
==========================================
Files 14 14
Lines 1227 1242 +15
Branches 204 207 +3
==========================================
+ Hits 999 1012 +13
- Misses 154 155 +1
- Partials 74 75 +1
Continue to review full report at Codecov.
|
3c7531a
to
d4c23c0
Compare
…reEventId = false
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #319 +/- ##
==========================================
+ Coverage 79.95% 80.02% +0.06%
==========================================
Files 17 17
Lines 1452 1467 +15
Branches 236 239 +3
==========================================
+ Hits 1161 1174 +13
- Misses 184 185 +1
- Partials 107 108 +1 ☔ View full report in Codecov by Sentry. |
Resolves #318