Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NLogLoggingConfiguration - Fix leak in RegisterChangeCallback #322

Merged
merged 2 commits into from
Aug 28, 2019

Conversation

snakefoot
Copy link
Contributor

@snakefoot snakefoot commented Aug 28, 2019

@snakefoot snakefoot force-pushed the NLogLoggingConfigurationLeak branch from 02977fd to 8f32937 Compare August 28, 2019 18:43
@codecov-io
Copy link

codecov-io commented Aug 28, 2019

Codecov Report

Merging #322 into master will decrease coverage by 0.38%.
The diff coverage is 60%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #322      +/-   ##
==========================================
- Coverage   81.44%   81.05%   -0.39%     
==========================================
  Files          12       12              
  Lines        1094     1098       +4     
  Branches      191      193       +2     
==========================================
- Hits          891      890       -1     
- Misses        141      143       +2     
- Partials       62       65       +3
Impacted Files Coverage Δ
...ensions.Logging/Config/NLogLoggingConfiguration.cs 91.86% <60%> (-2.29%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 407e66f...2888ab4. Read the comment docs.

@snakefoot snakefoot force-pushed the NLogLoggingConfigurationLeak branch from 8f32937 to 2888ab4 Compare August 28, 2019 19:16
@304NotModified 304NotModified merged commit d617f90 into NLog:master Aug 28, 2019
@304NotModified 304NotModified added this to the 1.5.3 milestone Aug 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants