Introduce AddNLog with NLog-config parameter #344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snakefoot
force-pushed
the
LoggerBuilderAddNLogLifetime
branch
2 times, most recently
from
0b1f10c to
4ebbfae
Compare
Codecov Report
@@ Coverage Diff @@
## master #344 +/- ##
==========================================
- Coverage 81.88% 81.63% -0.26%
==========================================
Files 12 12
Lines 1104 1127 +23
Branches 193 194 +1
==========================================
+ Hits 904 920 +16
- Misses 136 140 +4
- Partials 64 67 +3
Continue to review full report at Codecov.
|
snakefoot
force-pushed
the
LoggerBuilderAddNLogLifetime
branch
from
4ebbfae to
06b463c
Compare
snakefoot
force-pushed
the
LoggerBuilderAddNLogLifetime
branch
from
06b463c to
f42beeb
Compare
|
About the note: Thanks, but ive reverted the 1.6 in master already 👼 (Otherwise I see me making the mistake already ;) |
snakefoot
force-pushed
the
LoggerBuilderAddNLogLifetime
branch
2 times, most recently
from
86c43b4 to
18f428c
Compare
…ayoutRenderer first
snakefoot
force-pushed
the
LoggerBuilderAddNLogLifetime
branch
from
18f428c to
4d82408
Compare
|
This matches NLog/NLog.Web#484 (Just without ASP.NetCore) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will also allow AddNLog to automatically register
ConfigSettingLayoutRenderer.DefaultConfigurationby extractingIConfigurationfromServiceProvider(When not provided directly)