Update examples, created separate with Json config #352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
304NotModified
commented
Oct 19, 2019
| .AddJsonFile("appsettings.json", optional: true, reloadOnChange: true) | ||
| .Build(); | ||
|
|
||
| LogManager.Configuration = new NLogLoggingConfiguration(config.GetSection("NLog")); |
There was a problem hiding this comment.
@snakefoot maybe we should do this in loggingBuilder.AddNLog(config);, as we have already the config? Or is there a reason why we don't do that?
There was a problem hiding this comment.
Think the only reason is that AddNLog(config) has just been introduced moments ago.
Codecov Report
@@ Coverage Diff @@
## master #352 +/- ##
=======================================
Coverage 81.82% 81.82%
=======================================
Files 12 12
Lines 1150 1150
Branches 195 195
=======================================
Hits 941 941
Misses 140 140
Partials 69 69Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.