-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ActivityTraceLayoutRenderer - Renders System.Diagnostics.Activity.Current properties #359
ActivityTraceLayoutRenderer - Renders System.Diagnostics.Activity.Current properties #359
Conversation
Codecov Report
@@ Coverage Diff @@
## master #359 +/- ##
=======================================
Coverage 81.82% 81.82%
=======================================
Files 12 12
Lines 1150 1150
Branches 195 195
=======================================
Hits 941 941
Misses 140 140
Partials 69 69 Continue to review full report at Codecov.
|
668af5c
to
8167dd1
Compare
THanks! |
Starting to think that this should be moved into a separate nuget-package called https://www.nuget.org/packages/System.Diagnostics.DiagnosticSource/ Or maybe |
I think that's better too. |
Should new repository be created? |
I think that's the best, but also the most overhead |
Created new repository: |
Created #381 |
Resolves #358 for NetCoreApp3.
System.Diagnostics.Activity.Current
also exists in NetCoreApp2 and NetCoreApp21 and NetCoreApp22. But lets see what happens with NetCoreApp3.