Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ActivityTraceLayoutRenderer - Renders System.Diagnostics.Activity.Current properties #359

Merged
merged 2 commits into from
Dec 6, 2019

Conversation

snakefoot
Copy link
Contributor

Resolves #358 for NetCoreApp3.

System.Diagnostics.Activity.Current also exists in NetCoreApp2 and NetCoreApp21 and NetCoreApp22. But lets see what happens with NetCoreApp3.

@codecov-io
Copy link

codecov-io commented Nov 17, 2019

Codecov Report

Merging #359 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #359   +/-   ##
=======================================
  Coverage   81.82%   81.82%           
=======================================
  Files          12       12           
  Lines        1150     1150           
  Branches      195      195           
=======================================
  Hits          941      941           
  Misses        140      140           
  Partials       69       69

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b284fb6...8167dd1. Read the comment docs.

@snakefoot snakefoot force-pushed the ActivityTraceLayoutRenderer branch from 668af5c to 8167dd1 Compare November 17, 2019 23:00
@304NotModified 304NotModified self-assigned this Nov 17, 2019
@304NotModified 304NotModified merged commit f7ee149 into NLog:master Dec 6, 2019
@304NotModified
Copy link
Member

THanks!

@304NotModified 304NotModified added this to the 1.6.1 milestone Dec 6, 2019
@snakefoot
Copy link
Contributor Author

snakefoot commented Dec 21, 2019

Starting to think that this should be moved into a separate nuget-package called NLog.Layouts.ActivityTrace that depends on this nuget-package:

https://www.nuget.org/packages/System.Diagnostics.DiagnosticSource/

Or maybe NLog.Layouts.DiagnosticSource to match its dependency.

@304NotModified
Copy link
Member

I think that's better too.

@snakefoot
Copy link
Contributor Author

Should new repository be created?

@304NotModified
Copy link
Member

I think that's the best, but also the most overhead

@snakefoot
Copy link
Contributor Author

Created new repository:

https://github.com/NLog/NLog.DiagnosticSource

@snakefoot
Copy link
Contributor Author

Created #381

@snakefoot snakefoot removed this from the 1.6.2 milestone Dec 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for Activity.Current Baggage for .NET Core 3
3 participants