Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SonarLint warning about reducing number of conditional expressions #375

Merged
merged 1 commit into from
Dec 10, 2019

Conversation

snakefoot
Copy link
Contributor

No description provided.

@codecov-io
Copy link

codecov-io commented Dec 8, 2019

Codecov Report

Merging #375 into master will increase coverage by 0.03%.
The diff coverage is 85%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #375      +/-   ##
==========================================
+ Coverage   81.82%   81.85%   +0.03%     
==========================================
  Files          12       12              
  Lines        1150     1163      +13     
  Branches      195      192       -3     
==========================================
+ Hits          941      952      +11     
- Misses        140      141       +1     
- Partials       69       70       +1
Impacted Files Coverage Δ
...g.Extensions.Logging/Logging/NLogLoggerProvider.cs 95.23% <85%> (-1.95%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f7ee149...863f2ac. Read the comment docs.

@304NotModified
Copy link
Member

Thanks. If you also like to reduce the code complexity, you could use a dictionary instead of a switch.

@304NotModified
Copy link
Member

(oops wrong button )

@304NotModified 304NotModified reopened this Dec 9, 2019
@snakefoot
Copy link
Contributor Author

snakefoot commented Dec 9, 2019 via email

@304NotModified
Copy link
Member

ow yes, I mean list because of the startswith indeed!

@snakefoot snakefoot force-pushed the LoggerBuilderAddNLogLifetime branch from 471588d to 863f2ac Compare December 9, 2019 21:23
@304NotModified 304NotModified added this to the 1.6.1 milestone Dec 10, 2019
@304NotModified 304NotModified merged commit 7cb7213 into NLog:master Dec 10, 2019
@304NotModified
Copy link
Member

Nice! Thanks!

@snakefoot snakefoot modified the milestones: 1.6.1, 1.6.2 Dec 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants