Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NLogLoggerFactory - Emulate Microsoft LoggerFactory by returning same ILogger instance #380

Merged
merged 1 commit into from
Jan 21, 2020

Conversation

@codecov-io
Copy link

codecov-io commented Dec 29, 2019

Codecov Report

Merging #380 into master will increase coverage by 0.16%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #380      +/-   ##
==========================================
+ Coverage   81.85%   82.02%   +0.16%     
==========================================
  Files          12       12              
  Lines        1163     1174      +11     
  Branches      192      193       +1     
==========================================
+ Hits          952      963      +11     
  Misses        141      141              
  Partials       70       70
Impacted Files Coverage Δ
src/NLog.Extensions.Logging/Logging/NLogLogger.cs 80.5% <100%> (+0.21%) ⬆️
...og.Extensions.Logging/Logging/NLogLoggerFactory.cs 88.23% <100%> (+3.61%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7cb7213...2c1d254. Read the comment docs.

@snakefoot snakefoot added this to the 1.6.2 milestone Dec 30, 2019
@304NotModified 304NotModified merged commit 3f07a9c into NLog:master Jan 21, 2020
@304NotModified
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants