-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve AddNLog with LoggingConfiguration to handle custom LogFactory #407
Improve AddNLog with LoggingConfiguration to handle custom LogFactory #407
Conversation
Codecov Report
@@ Coverage Diff @@
## master #407 +/- ##
==========================================
+ Coverage 82.07% 82.08% +0.01%
==========================================
Files 12 12
Lines 1177 1178 +1
Branches 193 194 +1
==========================================
+ Hits 966 967 +1
Misses 141 141
Partials 70 70
Continue to review full report at Codecov.
|
Wow that was quick :) |
@snakefoot should we also change NLog.Extensions.Logging/src/NLog.Extensions.Logging/Extensions/ConfigureExtensions.cs Lines 193 to 198 in eb8a90f
? |
quick build times :) |
Since |
OK was also doubting about that. Unfortunately obsolete methods stay a bit long on highly used projects ;) |
Well nothing like a good carrot to lure them over the non-obsolete methods. |
Improves handling of #406