Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix documentation of default EventIdSeparator #429

Merged
merged 1 commit into from
May 27, 2020

Conversation

304NotModified
Copy link
Member

  • Fix documentation or default
  • move init to properties (so it's better visible)

- Fix documentation of default
- move init to properties
@codecov-commenter
Copy link

Codecov Report

Merging #429 into master will decrease coverage by 0.08%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #429      +/-   ##
==========================================
- Coverage   82.30%   82.22%   -0.09%     
==========================================
  Files          14       14              
  Lines        1204     1198       -6     
  Branches      200      200              
==========================================
- Hits          991      985       -6     
  Misses        141      141              
  Partials       72       72              
Impacted Files Coverage Δ
....Extensions.Logging/Logging/NLogProviderOptions.cs 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e5363f...8e24421. Read the comment docs.

@304NotModified 304NotModified changed the title Fix documentation of default Fix documentation of default EventIdSeparator May 27, 2020
Copy link
Contributor

@snakefoot snakefoot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great

@304NotModified 304NotModified merged commit 3c64a51 into master May 27, 2020
@304NotModified 304NotModified deleted the default-values-docs branch May 27, 2020 20:22
@304NotModified 304NotModified modified the milestones: 1.6.4, 1.6.5 Jun 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants