Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ShutdownOnDispose to work with isolated LogFactory #444

Merged
merged 1 commit into from
Aug 2, 2020

Conversation

snakefoot
Copy link
Contributor

@snakefoot snakefoot commented Aug 2, 2020

Fixing TODO. Resolves #442

@codecov-commenter
Copy link

Codecov Report

Merging #444 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #444   +/-   ##
=======================================
  Coverage   82.22%   82.22%           
=======================================
  Files          14       14           
  Lines        1198     1198           
  Branches      200      200           
=======================================
  Hits          985      985           
  Misses        141      141           
  Partials       72       72           
Impacted Files Coverage Δ
...g.Extensions.Logging/Logging/NLogLoggerProvider.cs 95.23% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce36d6c...3327eb1. Read the comment docs.

@304NotModified 304NotModified merged commit 0ec5cbf into NLog:master Aug 2, 2020
@304NotModified
Copy link
Member

Thanks!

@304NotModified 304NotModified added this to the 1.6.5 milestone Aug 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix todo with NLog 4.7.3
3 participants