Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NLogBeginScopeParser - Reduce allocation for BeginScope with message template #451

Merged
merged 1 commit into from
Oct 30, 2020

Conversation

snakefoot
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Sep 28, 2020

Codecov Report

Merging #451 into master will decrease coverage by 0.12%.
The diff coverage is 73.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #451      +/-   ##
==========================================
- Coverage   82.22%   82.09%   -0.13%     
==========================================
  Files          14       14              
  Lines        1198     1212      +14     
  Branches      200      202       +2     
==========================================
+ Hits          985      995      +10     
- Misses        141      144       +3     
- Partials       72       73       +1     
Impacted Files Coverage Δ
...Extensions.Logging/Logging/NLogBeginScopeParser.cs 66.87% <73.33%> (+0.43%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f903f1...fdd77cc. Read the comment docs.

@snakefoot snakefoot force-pushed the OptimizeSingleScopeProperty branch from 68eac68 to 8a0bcab Compare September 28, 2020 23:35
@pull-request-size pull-request-size bot added size/M and removed size/S labels Sep 28, 2020
@snakefoot snakefoot force-pushed the OptimizeSingleScopeProperty branch from 8a0bcab to fdd77cc Compare September 28, 2020 23:35
@304NotModified 304NotModified merged commit 9c3c6f0 into NLog:master Oct 30, 2020
@304NotModified 304NotModified added this to the 1.6.6 milestone Oct 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants