Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to NLog 5.0 Preview 1 with ScopeContext instead of MDLC #519

Merged
merged 1 commit into from
Aug 26, 2021

Conversation

snakefoot
Copy link
Contributor

No description provided.

@snakefoot snakefoot added this to the 5.0 milestone Aug 26, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #519 (cfd4314) into master (185d8b8) will increase coverage by 0.40%.
The diff coverage is 65.60%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #519      +/-   ##
==========================================
+ Coverage   79.88%   80.29%   +0.40%     
==========================================
  Files          17       17              
  Lines        1442     1411      -31     
  Branches      236      232       -4     
==========================================
- Hits         1152     1133      -19     
+ Misses        184      175       -9     
+ Partials      106      103       -3     
Impacted Files Coverage Δ
src/NLog.Extensions.Logging/Logging/NLogLogger.cs 81.75% <ø> (ø)
....Extensions.Logging/Logging/NLogProviderOptions.cs 100.00% <ø> (ø)
...Extensions.Logging/Logging/NLogBeginScopeParser.cs 67.42% <65.32%> (+1.25%) ⬆️
...tensions.Logging/Targets/MicrosoftILoggerTarget.cs 84.07% <100.00%> (+0.42%) ⬆️
...ensions.Logging/Config/NLogLoggingConfiguration.cs 89.22% <0.00%> (-0.44%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 185d8b8...cfd4314. Read the comment docs.

@snakefoot snakefoot merged commit d7384e7 into NLog:master Aug 26, 2021
@snakefoot
Copy link
Contributor Author

snakefoot commented Aug 26, 2021

Performance is still good with official NLog 5.0.0-preview.1:

Test Name Messages Size Args Threads
NLog Async 5.000.000 34 2 1
Test Name Time (ms) Msgs/sec GC2 GC1 GC0 CPU (ms) Alloc (MB)
NLog 5.0.0 7.137 700.530 1 48 114 10.906 2.785,8
NLog 4.7.11 9.283 538.584 1 94 242 14.218 4.921,8

This is the performance-numbers of ILogger.BeginScope where LogLevel is disabled:

Test Name Messages Size Args Threads
NLog Async 50.000.000 34 2 1
Test Name Time (ms) Msgs/sec GC2 GC1 GC0 CPU (ms) Alloc (MB)
NLog 5.0.0 9.037 5.532.803 0 1 494 8.906 6.485,0
NLog 4.7.11 29.706 1.683.144 0 2 2131 29.171 27.847,3

@snakefoot
Copy link
Contributor Author

@304NotModified I don't have any more pull-request planned for NLog.Extensions.Logging ver. 5.0.0-preview.1

Do you have any planned changes?

@304NotModified
Copy link
Member

Do you have any planned changes?

For NLog 5 or NLog.Extensions.Logging 5?

@snakefoot
Copy link
Contributor Author

NLog.Extensions.Logging 5-preview1

@304NotModified
Copy link
Member

I Checked the issues , only #526 would be nice

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants