Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BeginScope to recognize ITuple with better support for AOT #768

Merged
merged 3 commits into from
Oct 27, 2024

Conversation

snakefoot
Copy link
Contributor

@snakefoot snakefoot commented Oct 27, 2024

AOT doesn't like reflection of generic types like typeof(ValueTuple<,>) and typeof(KeyValuePair<,>)

@snakefoot snakefoot changed the title BeginScope now recognize ITuple to prepare for AOT BeginScope now recognize ITuple with better support for AOT Oct 27, 2024
@pull-request-size pull-request-size bot added size/M and removed size/S labels Oct 27, 2024
@snakefoot snakefoot force-pushed the master branch 3 times, most recently from 4734c5d to 1ba12c9 Compare October 27, 2024 16:18
@pull-request-size pull-request-size bot added size/L and removed size/M labels Oct 27, 2024
@snakefoot snakefoot changed the title BeginScope now recognize ITuple with better support for AOT BeginScope to recognize ITuple with better support for AOT Oct 27, 2024
@snakefoot snakefoot merged commit 71af10a into NLog:master Oct 27, 2024
3 checks passed
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.76%. Comparing base (b5675a0) to head (b57f815).
Report is 1 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #768      +/-   ##
==========================================
+ Coverage   81.51%   81.76%   +0.25%     
==========================================
  Files          19       19              
  Lines        1807     1810       +3     
  Branches      320      321       +1     
==========================================
+ Hits         1473     1480       +7     
+ Misses        190      188       -2     
+ Partials      144      142       -2     
Flag Coverage Δ
?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants