NLogAspNetCoreOptions - Enable ShutdownOnDispose by default (#691)

NLog · Aug 30, 2021 · 9c42f97 · 9c42f97
1 parent b5b5511
commit 9c42f97
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 5 deletions.
diff --git a/src/NLog.Web.AspNetCore/AspNetExtensions.cs b/src/NLog.Web.AspNetCore/AspNetExtensions.cs
@@ -343,13 +343,15 @@ private static NLogLoggerProvider CreateNLogLoggerProvider(IServiceProvider serv
             NLogLoggerProvider provider = new NLogLoggerProvider(options ?? NLogAspNetCoreOptions.Default, logFactory ?? LogManager.LogFactory);
             if (configuration != null)
             {
-                if (options == null)
-                {
-                    provider.Configure(configuration.GetSection("Logging:NLog"));
-                }
-
+                provider.Configure(configuration.GetSection("Logging:NLog"));
                 TryLoadConfigurationFromSection(provider, configuration);
             }
+
+            if (provider.Options.ShutdownOnDispose)
+            {
+                provider.LogFactory.AutoShutdown = false;
+            }
+
             return provider;
         }
 

diff --git a/src/NLog.Web.AspNetCore/NLogAspNetCoreOptions.cs b/src/NLog.Web.AspNetCore/NLogAspNetCoreOptions.cs
@@ -20,5 +20,13 @@ public sealed class NLogAspNetCoreOptions : NLogProviderOptions
         /// The default options
         /// </summary>
         public static NLogAspNetCoreOptions Default { get; } = new NLogAspNetCoreOptions();
+
+        /// <summary>
+        /// Initializes a new instance of <see cref="NLogAspNetCoreOptions"/> with default values.
+        /// </summary>
+        public NLogAspNetCoreOptions()
+        {
+            ShutdownOnDispose = true;
+        }
     }
 }